From fbea57746ed85665b1177f1b1ea0184617585bf5 Mon Sep 17 00:00:00 2001
From: Benoit Lavenier <benoit.lavenier@e-is.pro>
Date: Sat, 28 May 2016 20:28:07 +0200
Subject: [PATCH] Update settings options order. Hide remember me when local
 storage disable

---
 www/i18n/locale-en.json                    |  5 +--
 www/i18n/locale-fr-FR.json                 |  5 +--
 www/js/controllers/settings-controllers.js |  2 ++
 www/templates/settings/settings.html       | 38 ++++++++++++++--------
 4 files changed, 33 insertions(+), 17 deletions(-)

diff --git a/www/i18n/locale-en.json b/www/i18n/locale-en.json
index 02e9c1eb3..7e683b611 100644
--- a/www/i18n/locale-en.json
+++ b/www/i18n/locale-en.json
@@ -54,10 +54,11 @@
   },
   "SETTINGS": {
     "TITLE": "Setting",
-    "TECHNICAL_SETTINGS": "Technical settings",
-    "NODE": "Duniter Node",
+    "NETWORK_SETTINGS": "Network",
+    "NODE": "Node address",
     "NODE_HELP": "server.domain.com:port",
     "USE_LOCAL_STORAGE": "Enable local storage",
+    "AUTHENTICATION_SETTINGS": "Authentication",
     "REMEMBER_ME": "Remember me",
     "POPUP_NODE": {
       "TITLE" : "Duniter Node",
diff --git a/www/i18n/locale-fr-FR.json b/www/i18n/locale-fr-FR.json
index 3ac8c44ac..da6ea34eb 100644
--- a/www/i18n/locale-fr-FR.json
+++ b/www/i18n/locale-fr-FR.json
@@ -54,10 +54,11 @@
   },
   "SETTINGS": {
     "TITLE": "Paramètres",
-    "TECHNICAL_SETTINGS": "Paramètres techniques",
-    "NODE": "Noeud Duniter",
+    "NETWORK_SETTINGS": "Réseau",
+    "NODE": "Adresse du noeud",
     "NODE_HELP": "server.domain.com:port",
     "USE_LOCAL_STORAGE": "Activer le stockage local",
+    "AUTHENTICATION_SETTINGS": "Authentification",
     "REMEMBER_ME": "Se rappeller de moi",
     "POPUP_NODE": {
       "TITLE" : "Noeud Duniter",
diff --git a/www/js/controllers/settings-controllers.js b/www/js/controllers/settings-controllers.js
index 7fcf6f7cf..54846aec7 100644
--- a/www/js/controllers/settings-controllers.js
+++ b/www/js/controllers/settings-controllers.js
@@ -125,8 +125,10 @@ function SettingsController($scope, $state, UIUtils, Wallet, $translate, BMA, $q
 
   $scope.onSettingsChanged = function() {
     if (!$scope.loading) {
+      $scope.loading = true;
       angular.merge(Wallet.data.settings, $scope.formData);
       Wallet.store();
+      $scope.loading = false;
     }
   };
   $scope.$watch('formData', $scope.onSettingsChanged, true);
diff --git a/www/templates/settings/settings.html b/www/templates/settings/settings.html
index 734829233..9618ddd95 100644
--- a/www/templates/settings/settings.html
+++ b/www/templates/settings/settings.html
@@ -4,13 +4,15 @@
 
     <ion-content >
         <div class="item item-toggle dark">
+          <div class="input-label">
             {{'COMMON.BTN_RELATIVE_UNIT' | translate}}
-            <label class="toggle toggle-royal">
-                <input type="checkbox" ng-model="formData.useRelative">
-                <div class="track">
-                    <div class="handle"></div>
-                </div>
-            </label>
+          </div>
+          <label class="toggle toggle-royal">
+              <input type="checkbox" ng-model="formData.useRelative">
+              <div class="track">
+                  <div class="handle"></div>
+              </div>
+          </label>
         </div>
 
       <label class="item item-input item-select">
@@ -24,9 +26,11 @@
       </label>
 
       <div class="item item-toggle dark">
-        {{'SETTINGS.REMEMBER_ME' | translate}}
+        <div class="input-label">
+         {{'SETTINGS.USE_LOCAL_STORAGE' | translate}}
+        </div>
         <label class="toggle toggle-royal">
-          <input type="checkbox" ng-model="formData.rememberMe" >
+          <input type="checkbox" ng-model="formData.useLocalStorage" >
           <div class="track">
             <div class="handle"></div>
           </div>
@@ -34,24 +38,32 @@
       </div>
 
       <span class="item item-divider">
-        {{'SETTINGS.TECHNICAL_SETTINGS' | translate}}
+        {{'SETTINGS.NETWORK_SETTINGS' | translate}}
       </span>
 
       <div class="item ink" ng-click="changeNode()">
+        <div class="input-label">
         {{'SETTINGS.NODE' | translate}}
+        </div>
         <span class="item-note">{{formData.node}}</span>
       </div>
 
-      <div class="item item-toggle dark">
-        {{'SETTINGS.USE_LOCAL_STORAGE' | translate}}
+      <span class="item item-divider" ng-if="formData.useLocalStorage">
+        {{'SETTINGS.AUTHENTICATION_SETTINGS' | translate}}
+      </span>
+
+      <div class="item item-toggle dark" ng-if="formData.useLocalStorage">
+        <div class="input-label">
+          {{'SETTINGS.REMEMBER_ME' | translate}}
+        </div>
         <label class="toggle toggle-royal">
-          <input type="checkbox" ng-model="formData.useLocalStorage" >
+          <input type="checkbox" ng-model="formData.rememberMe"
+            >
           <div class="track">
             <div class="handle"></div>
           </div>
         </label>
       </div>
 
-
     </ion-content>
 </ion-view>
-- 
GitLab