Make Transaction multi-sign by default

• Store SigningKey and Signature arguments/attributes in Lists
• Overwrite Document.{sign(),check_signature()} as undefined

changed milestone to %Backlog

added D: Transfer Feature labels

mentioned in merge request !144 (merged)

There is a typo here:

List[SigningKey] = None

should be:

Optional[List[SigningKey]] = None

If signing_keys is not a list, you can not sign anything as it is None.

changed title from Introduce Transaction multi-sign feature in the consturctor to Introduce Transaction multi-sign feature in the constructor

changed the description

changed the description

changed title from Introduce Transaction multi-sign feature in the constructor to Make Transaction multi-sign by default

changed the description

assigned to @moul

changed milestone to %1.0.0

mentioned in commit 8bd0c7c9

mentioned in merge request !150 (merged)

Ok, to support multi-sign in the constructor, but it must not get in the way of single signature.

I don't want the user to be forced to give a list for everyday use case where a single SigningKey only is needed. It is not KISS.

Transaction.__init__(signing_keys: Optional[Union[SigningKey, List[SigningKey]] = None)

is what I want.

Please write this argument, as it will appear in the constructor, in the issue description.

mentioned in commit e5be93fe

Can you check !150 (merged). I added a commit.

I am not a big fan of handling two types: the list of instance and the instance. It makes more cases to handle and to test. More cases means more bugs. On the other hand, it makes it more convenient to be able to pass a single or multiple instances.

Fine! Great job in the last commit! I have just commented on the constructor as it seems type casting to list is useless for multi_sign now.

mentioned in commit 4f17e72c

mentioned in commit 43d71a24

mentioned in commit 717b63fb

closed with merge request !150 (merged)

mentioned in commit 04ecedc2