Implement InputSource and OutputSource equality and hash methods

Here we are after moulte types errors!!

---

Implementation

In Silkaj, I need to check the equality of InputSource:

• __eq__() implementation, to allow: inputsource1 == inputsource2

• __hash__() methods should also be implemented. As I understood, it allows those classes stored into dict() and set() to continue working properly.

• I also did it for OutputSource, as it’s pretty similar.

---

Readings

• https://hynek.me/articles/hashes-and-equality/
• https://stackoverflow.com/questions/390250/elegant-ways-to-support-equivalence-equality-in-python-classes
• https://medium.com/@s16h/pythons-notimplemented-type-2d720137bf41

---

Types

I don’t if we can handle the type of the other argument. I tried, but I think it’s already checked with following block:

        if not isinstance(other, InputSource):
            return NotImplemented

In current code I found Any, and object.

---

One commit to change the return value within the equality method when it is not implemented between two different classes from False to NotImplemented.

---

Release

We can either wait for 0.54, or I can take care to release a 0.53.1.

changed milestone to %0.54.x

changed the description

changed the description

I will check it tomorrow and let you make a release 0.53.1. As Duniterpy became a big part of Silkaj it is normal that you can do some improvements and do releases more frequently.

Stay tuned !

changed the description

changed milestone to %0.53.x

added 3 commits

• 4c30cf3f - [feat] InputSource: add equality and hash methods
• 872bbcc3 - [feat] OutputSource: add equality and hash methods
• dce62484 - [mod] __eq__(): return NotImplemented in case of equality between different classes

Compare with previous version

added 1 commit

• b418e8a7 - [enh] enhance indentation and others minors things

Compare with previous version

merged

mentioned in commit c2e016a1

I've cleaned up some indentation warning in Pycharm, and merged.

You can do a 0.53.1 release !

Be sure that the release.sh script do the right things before pushing the release on PyPI.

Thanks for your work !

added Feature label

added Money label