Skip to content
Snippets Groups Projects

#58: WS2P support

Merged #58: WS2P support
All threads resolved!
Merged Vincent Texier requested to merge ws2p into dev
All threads resolved!

#58 (closed): Add the ws2p API support and examples

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Moul
  • Moul
  • Moul assigned to @moul and unassigned @vtexier

    assigned to @moul and unassigned @vtexier

  • Moul
  • Moul
  • Moul
  • Moul
  • Here is my first code review.

    The code looks good and is very clean which is appreciable to read.

    Great work!

    After a working example, I will give a second review.

  • Vincent Texier added 5 commits

    added 5 commits

    Compare with previous version

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Vincent Texier added 1 commit

    added 1 commit

    • cdadeb55 - [enh] refactor request_ws2p.py with a send function

    Compare with previous version

  • All corrections from review done, except validation in receive_json().

    I think you can take a look at the last commits and tell me if I can rebase/merge on dev...

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Moul changed title from Ws2p to WS2P support

    changed title from Ws2p to WS2P support

  • Moul changed title from WS2P support to #58: WS2P support

    changed title from WS2P support to #58: WS2P support

  • Moul changed the description

    changed the description

  • Moul
  • Vincent Texier added 7 commits

    added 7 commits

    Compare with previous version

  • mentioned in issue silkaj#229 (closed)

  • Moul added 11 commits

    added 11 commits

    Compare with previous version

  • I dropped the pylint commit. I added three commits on top of the chain:

    • Copyright headers on three introduced files
    • Introduce WS2P endpoint generator helper from BMA endpoint
      • with tests compatible with pytest
    • Usage of this helper into the examples.

    Now that the examples are flexible. We can easily change node. I am still not able to initiate a connexion on a WS2P endpoint. I would need your help on that field.

    Edited by Moul
  • Moul resolved all threads

    resolved all threads

  • Moul added 1 commit

    added 1 commit

    Compare with previous version

  • Moul added 3 commits

    added 3 commits

    Compare with previous version

  • Moul added 1 commit

    added 1 commit

    Compare with previous version

  • Moul added 2 commits

    added 2 commits

    Compare with previous version

  • Moul
  • Moul added 2 commits

    added 2 commits

    Compare with previous version

  • Moul added 3 commits

    added 3 commits

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • Vincent Texier added 2 commits

    added 2 commits

    Compare with previous version

  • Vincent Texier added 42 commits

    added 42 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading