silkaj issueshttps://git.duniter.org/clients/python/silkaj/-/issues2024-03-27T21:18:01+01:00https://git.duniter.org/clients/python/silkaj/-/issues/487Move sources in `src` directory2024-03-27T21:18:01+01:00MoulMove sources in `src` directory…as [recommended by Python packaging](https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/).
- [ ] Move `silkaj` directory in `src` directory
- [ ] Add this commit in a `.git-blame-ignore-revs`?…as [recommended by Python packaging](https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/).
- [ ] Move `silkaj` directory in `src` directory
- [ ] Add this commit in a `.git-blame-ignore-revs`?Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/485Bump copyright to 20252023-12-09T14:01:05+01:00MoulBump copyright to 2025- [ ] Update to 2025:
- [In the header file](https://git.duniter.org/clients/python/silkaj/-/blob/main/CONTRIBUTING.md#update-copyright-year)
- In MkDocs config once #433+ is done
- [ ] Open ticket for 2026 and link it to this one- [ ] Update to 2025:
- [In the header file](https://git.duniter.org/clients/python/silkaj/-/blob/main/CONTRIBUTING.md#update-copyright-year)
- In MkDocs config once #433+ is done
- [ ] Open ticket for 2026 and link it to this one0.20.02024-12-10https://git.duniter.org/clients/python/silkaj/-/issues/471Rename transfer’s comment to reference2023-06-30T16:20:34+02:00MoulRename transfer’s comment to referenceBanks are using this term: _Payment reference_.
This is more what we are aiming for.
- [ ] Rename CLI option: `silkaj money transfer -c/--comment` −> `-ref/--reference`. `-r` is already used by `--recipient`
- [ ] Rename UI fields of `t...Banks are using this term: _Payment reference_.
This is more what we are aiming for.
- [ ] Rename CLI option: `silkaj money transfer -c/--comment` −> `-ref/--reference`. `-r` is already used by `--recipient`
- [ ] Rename UI fields of `transfer` and `history` commands
- [ ] Adapt run time code and tests. Keep it named `comment` when using DuniterPy document, that’s the interface we won’t change.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/434Readme: Structure badges in a table2023-09-09T17:57:17+02:00MoulReadme: Structure badges in a table- [ ] Add [Poetry badge](https://python-poetry.org/docs/community/#badge)
- [ ] Structure badges in a table as on [`hatch` readme](https://github.com/pypa/hatch/blob/master/README.md#hatch).- [ ] Add [Poetry badge](https://python-poetry.org/docs/community/#badge)
- [ ] Structure badges in a table as on [`hatch` readme](https://github.com/pypa/hatch/blob/master/README.md#hatch).Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/405Use currencies codenames constants2022-06-05T15:23:54+02:00MoulUse currencies codenames constantsThis is what can be found in the blockchains.
- Will be defined in `duniterpy/constants.py` from v1.0 (duniterpy!144):
```bash
G1_CURRENCY_CODENAME = "g1"
GTEST_CURRENCY_CODENAME = "g1-test"
```
- [ ] Use them in Silkaj by replacing the...This is what can be found in the blockchains.
- Will be defined in `duniterpy/constants.py` from v1.0 (duniterpy!144):
```bash
G1_CURRENCY_CODENAME = "g1"
GTEST_CURRENCY_CODENAME = "g1-test"
```
- [ ] Use them in Silkaj by replacing the strings.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/350Set the priority to the passed pubkey over the authentication method for `bal...2023-08-16T21:11:26+02:00MoulSet the priority to the passed pubkey over the authentication method for `balance` and `checksum` cmdsCommands allowing to pass a pubkey via the authentication and the usual CLI (`balance` and `checksum` for now) are prioritizing the authentication methods over the pubkey.
@matograine suggested to prioritize the pubkey over the authentic...Commands allowing to pass a pubkey via the authentication and the usual CLI (`balance` and `checksum` for now) are prioritizing the authentication methods over the pubkey.
@matograine suggested to prioritize the pubkey over the authentication method or return an error.
That could be an issue when `silkaj -af` is set as a shell alias, where the authentication would always be set on every command, then the user would forget about it, and get the result for public key from the authentication file.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/328Import modules in an upper level to not cause issue while monkeypatching2022-03-13T18:09:28+01:00MoulImport modules in an upper level to not cause issue while monkeypatching### Problem
Following `pep8` recommendations to import just the necessary function used in the code.
And following what I heard about importing just the minimum to speed-up the program start-up, and may be decrease the memory usage by ke...### Problem
Following `pep8` recommendations to import just the necessary function used in the code.
And following what I heard about importing just the minimum to speed-up the program start-up, and may be decrease the memory usage by keeping the minimum libs in the memory.
This two above statement made silkaj runtime code just import the strict minimum of what's used.
We are now starting to write more and more tests, and this caused troubles. Monkeypatching wasn't working due to import issues.
[This article](https://medium.com/@chipiga86/python-monkey-patching-like-a-boss-87d7ddb8098e) explains why the monkey patching is sometimes not working due to import issues. As a summary, this is due to how the modules are imported. Once imported and cached, it can not be changed. But, if you import at a higher level, via the above module, the patching is working.
### Solution
This ticket is just about changing the modules import, by importing them from a higher level:
```
from silkaj import tx
tx.send_transaction()
tx.confirmation_chart()
```
We could import a whole file, a class, but not a function nor a method, otherwise we would get annoyed by non-working monkeypatching.
This also allow to know from which library the f() is coming from, the context. There will be less effort tracking which function is use/is no more used and can be removed.
The idea is to get into this direction. We could still import function and method if wished.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/277Store releases announcements into this git repository2024-03-11T22:36:40+01:00MoulStore releases announcements into this git repositoryCould be into this repository, but in the website repository it would make more sense. As we have to store images, and this could be displayed on a blog, changelog page.
- [v0.11.{1,2}](https://forum.duniter.org/t/silkaj-v0-11-0-release/...Could be into this repository, but in the website repository it would make more sense. As we have to store images, and this could be displayed on a blog, changelog page.
- [v0.11.{1,2}](https://forum.duniter.org/t/silkaj-v0-11-0-release/10087/3)
- [v0.8.1](https://forum.duniter.org/t/silkaj-v0-8-0-release/7686/7)
- !145+
- [Silkaj v0.7.x releases: DuniterPy](https://forum.duniter.org/t/silkaj-v0-7-x-releases-duniterpy/6099)
- [Silkaj v0.6.x releases: Let’s install](https://forum.duniter.org/t/silkaj-v0-6-x-releases-let-s-install/4858)
- [Silkaj v0.5.0 release: Let’s certify!](https://forum.duniter.org/t/silkaj-v0-5-0-release-let-s-certify/4712)
- [Silkaj v0.4.0 release](https://forum.duniter.org/t/silkaj-v0-4-0-release/4071)
- [Silkaj v0.3.0 release: Let's send money!](https://forum.duniter.org/t/silkaj-v0-3-0-release-lets-send-money/2404)
- [No announcement for the v0.2.0: just a changelog, the announcement was done in the v0.3.0 looks like](https://git.duniter.org/clients/python/silkaj/-/releases)
- [Silkaj: new CLI Duniter client](https://forum.duniter.org/t/silkaj-new-cli-duniter-client/1278)
## Todos
- [ ] Import them, including images
- [ ] Proofreads them
- [ ] Fix milestones hard-coded urls, missing `/-/milestone/#`, use i.e. %"0.20.0" instead0.20.0https://git.duniter.org/clients/python/silkaj/-/issues/266Create issue templates2021-03-15T17:29:55+01:00MoulCreate issue templates## Issue templates examples
- [Geary](https://gitlab.gnome.org/GNOME/geary/tree/mainline/.gitlab/issue_templates)
- [Poetry](https://github.com/python-poetry/poetry/tree/master/.github)
### Bug report fields
- [ ] You have search if you...## Issue templates examples
- [Geary](https://gitlab.gnome.org/GNOME/geary/tree/mainline/.gitlab/issue_templates)
- [Poetry](https://github.com/python-poetry/poetry/tree/master/.github)
### Bug report fields
- [ ] You have search if your issue is not already addressed?
- Installation mean: `Debian`, `pip`, `poetry`
- Silkaj version:
- Python/pip versions:
- OS:
- …
## MR template
- Can it also be done for MR?Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/254Document commit message format2023-04-10T11:44:30+02:00MoulDocument commit message format- [Git : comment nommer ses branches et ses commits ?](https://www.codeheroes.fr/2020/06/29/git-comment-nommer-ses-branches-et-ses-commits/)
>[type] #XXXX: [cmd_name]: short description:
>
>- detailed description
>- explaining the impor...- [Git : comment nommer ses branches et ses commits ?](https://www.codeheroes.fr/2020/06/29/git-comment-nommer-ses-branches-et-ses-commits/)
>[type] #XXXX: [cmd_name]: short description:
>
>- detailed description
>- explaining the important changes made
- `XXXX`: ticket number
- `[cmd_name]`: optional, to get the context of a change
## types
- code change:
- runtime:
- `fix`: bug fix
- `mod`: modification of existing code without significant improvement
- `enh`: enhancement: improvement of existing code
- `feat`: new feature
- `test`: tests writing, change, and modification
- `fmt`: Black formatting
- `lint`: Linting, `pylint`
- `type`: `mypy`
- CI/CD `.gitlab-ci.yml`:
- `ci`: continuous integration
- `cd`: continuous delivery
- `doc`: documentation, `README.md` `AUTHORS.md` ″CHANGELOG.md` change
- `dep`: dependency introduction, update, management.
- …
---
- GitLab V12.7: [Configure default commit message for applied Suggestions ](https://about.gitlab.com/releases/2020/01/22/gitlab-12-7-released/#configure-default-commit-message-for-applied-suggestionss)Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/219Use `id_from_pubkeys()` in `blocks` and `net` commands2022-06-26T22:35:49+02:00MoulUse `id_from_pubkeys()` in `blocks` and `net` commandsUse `id_from_pubkeys()` in `blocks` and `net` commands.
This function will most likely become useless when migrating to GVA usage.Use `id_from_pubkeys()` in `blocks` and `net` commands.
This function will most likely become useless when migrating to GVA usage.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/139Add command allowing to converts between relative (UD) and quantitative amounts2022-10-27T16:23:15+02:00MoulAdd command allowing to converts between relative (UD) and quantitative amountsWith current UD value and even with older UD values.With current UD value and even with older UD values.Backloghttps://git.duniter.org/clients/python/silkaj/-/issues/65Add a gif to explain the usage2019-06-03T09:23:48+02:00MoulAdd a gif to explain the usage- [Like on this readme](https://github.com/nirvik/iWant)- [Like on this readme](https://github.com/nirvik/iWant)Backlog