Merge the two functions testing transaction_amount()
Two functions are testing transaction_amount()
in test_{,unit_}tx.py
:
- Merge the functions? at least put them together
- Move
test_unit_tx.py
content intest_tx.py
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Moul added D: Transfer Test labels
added D: Transfer Test labels
- Maintainer
I am doing this, just wondering :
sould it not be the test in test_tx.py that would go in test_unit_tx.py ? This is unit testing, right ?
Please assign to you the ticket if you are working on it. This way we know what you are doing (this is not for tracking
), and two contributors do not work on the same ticket.I would move the ones in test_tx.py to test_unit_tx.py for now, since we do not have a clear separation of unit and integration tests. There might be a ticket for that. But, let's clarify this later. I mention a bit this problem in #147 (comment 23287).
- matograine assigned to @matograine
assigned to @matograine
- matograine mentioned in commit ad7eb545
mentioned in commit ad7eb545
- Moul mentioned in merge request !130 (merged)
mentioned in merge request !130 (merged)
- matograine mentioned in commit 9cf9a45e
mentioned in commit 9cf9a45e
- matograine mentioned in commit 52293dbd
mentioned in commit 52293dbd
- matograine mentioned in commit cb13f399
mentioned in commit cb13f399
- matograine mentioned in commit 005b705d
mentioned in commit 005b705d
- matograine closed with merge request !130 (merged)
closed with merge request !130 (merged)
- Moul changed title from Two functions are testing transaction_amount() to Merge the two functions testing transaction_amount()
changed title from Two functions are testing transaction_amount() to Merge the two functions testing transaction_amount()