Write checksum tests on every commands
The following discussion from !143 (merged) should be addressed:
-
@moul started a discussion:
Thanks for writing these tests!
The best would have been to have test written for all command to test that we can pass an uid, a pubkey, pubkey+checksum. That the checksums are validated. I am afraid we don't have time for that. It should be planned for next release.
In the case we want to continue using the <pubkey>:<checksum> checksum system, and not using #341 base58.b58(de|en)code_check(), writing checksum tests on every commands should be done:
- Passing a pubkey
- Passing a pubkey + valid checksum
- Passing a pubkey + invalid checksum
- Passing an
uidtowot,cert, …
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information