silkaj merge requestshttps://git.duniter.org/clients/python/silkaj/-/merge_requests2019-11-24T13:47:32+01:00https://git.duniter.org/clients/python/silkaj/-/merge_requests/105WIP : #111 Send multiple outputs2019-11-24T13:47:32+01:00matograineWIP : #111 Send multiple outputsAdding the function to send multiple outputs. This MR uses the !104 changed confirmation display, I don't know if this is the right way to submit MRs.
Adding total_amount() function.
Variables amounts and OutputAddresses should no...Adding the function to send multiple outputs. This MR uses the !104 changed confirmation display, I don't know if this is the right way to submit MRs.
Adding total_amount() function.
Variables amounts and OutputAddresses should now be lists. However, I kept the case where it is a string. This might be removed if not necessary, but I didn't want to break anything (I broke the intermediary_tx function during development).
I took care of intermediary transactions, and [tested it on GTest](https://ts.gt.librelois.fr/blockchain/block/423275).
I tried to write tests, however, I could not run them due to #241 (Click). I did not use Poetry for now, it seems to be the workaround.
!! CAUTION !! I had to deal with the base issue on testing (Gtest). There are two round (amount, -2) in function transaction_amount() that should be removed before merging.0.8.0MoulMoulhttps://git.duniter.org/clients/python/silkaj/-/merge_requests/114Close the client in case of a negative answer to the confirmation2019-11-22T08:12:59+01:00MoulClose the client in case of a negative answer to the confirmationAddress issue from !112
- [fix] Close the client in case of a negative answer to the confirmation
- for tx and cert commands
- [enh] Introduce exit status constants
---
Note: You can review this change.
If it actually fix the...Address issue from !112
- [fix] Close the client in case of a negative answer to the confirmation
- for tx and cert commands
- [enh] Introduce exit status constants
---
Note: You can review this change.
If it actually fix the issue, is correctly implemented and does not introduce new bug, tell me if you approve it.
Then I will merge it.0.8.0matograinematograinehttps://git.duniter.org/clients/python/silkaj/-/merge_requests/112[enh] : clean exit on "no" answer2019-11-22T08:12:32+01:00matograine[enh] : clean exit on "no" answer* add "else" statement on transaction confirmation in send_transaction() function.
* on "no" answer, silkaj now makes a clean exit with message_exit()* add "else" statement on transaction confirmation in send_transaction() function.
* on "no" answer, silkaj now makes a clean exit with message_exit()0.8.0MoulMoulhttps://git.duniter.org/clients/python/silkaj/-/merge_requests/104#236 : change confirmation display2019-10-13T14:22:30+02:00matograine#236 : change confirmation displaylighter confirmation display.
addfunctions :
display_amount()
display_pubkey()
display_output_and_amount()lighter confirmation display.
addfunctions :
display_amount()
display_pubkey()
display_output_and_amount()0.8.0MoulMoulhttps://git.duniter.org/clients/python/silkaj/-/merge_requests/99WIP: Output backchange #1652019-08-01T13:31:40+02:00matograineWIP: Output backchange #165Worked on issue 165 : outputBackChange.
Not sure if my merge request is correctly done. There are merge conflicts and I don't know how to correct it.
btw, I wrote this feature, but I don't understand why "backchange" != (previous_a...Worked on issue 165 : outputBackChange.
Not sure if my merge request is correctly done. There are merge conflicts and I don't know how to correct it.
btw, I wrote this feature, but I don't understand why "backchange" != (previous_amount - tx_amount).
So, maybe I missed a point. Like the amount of backchange.0.7.0MoulMoul