Ğ1 license display on a workstation: give the choice how to display it

While certifying an account (on 0.7.6), the license does not get displayed:

Please enter your Scrypt Salt (Secret identifier): 
Please enter your Scrypt password (masked): 
You will be asked to approve Ğ1 license. Would you like to display it? [y/N]: y
In which language would you like to display Ğ1 license [en/fr]? fr
Do you approve Ğ1 license? [y/N]: y
...

changed milestone to %0.8.0

added Bug CLI Web of Trust labels

removed CLI Web of Trust labels

added Dev Env label

changed title from license not displayed to Ğ1 license not displayed

silkaj license
In which language would you like to display Ğ1 license [en/fr]? 
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/moul/.cache/pypoetry/virtualenvs/silkaj-58dUTebQ-py3.7/lib64/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/moul/.cache/pypoetry/virtualenvs/silkaj-58dUTebQ-py3.7/lib64/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/moul/.cache/pypoetry/virtualenvs/silkaj-58dUTebQ-py3.7/lib64/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/moul/.cache/pypoetry/virtualenvs/silkaj-58dUTebQ-py3.7/lib64/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/moul/.cache/pypoetry/virtualenvs/silkaj-58dUTebQ-py3.7/lib64/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/moul/silkaj/silkaj/license.py", line 34, in license_command
    display_license()
  File "/home/moul/silkaj/silkaj/license.py", line 44, in display_license
    echo_via_pager(open("licence-G1/license/license_g1-fr-FR.rst").read())
FileNotFoundError: [Errno 2] No such file or directory: 'licence-G1/license/license_g1-fr-FR.rst'

If you are getting upper issue, then I am aware of this issue. If not, could you describe the context, installation, headless machine?

If so, this is only happening within the devenv and on a headless machine (without a web browser).

Then, the license files are not found.

This should be addressed by #221 (closed).

changed the description

@matograine?

changed milestone to %0.9.0

I am in a dev env (poetry shell) and on a machine with a browser. Debian 10.

I have absolutely no license shown, nor error :

(silkaj-HKHTj0CI-py3.7) ~$ silkaj license
In which language would you like to display Ğ1 license [en/fr]? en
(silkaj-HKHTj0CI-py3.7) ~$ 

edit - well, yes, Silkaj opens up a browser on the webpage of the license. I was expecting the license to be displayed in the terminal.

Maybe add a line saying "opening the license in your browser..." ?

Yep, I already thought about giving the choice on a workstation: opening the license in web browser or in the terminal.

I suggest to make it the topic of this ticket.

Default would be in the terminal. To switch to display in the web browser, user following general option:

-w/--g1-license-web   Display Ğ1 banking license in a web browser if not running an a headless machine. Defaults to display it in the terminal.

added enhancement label and removed Bug Dev Env labels

changed title from Ğ1 license not displayed to Ğ1 license: give the choice on a workstation how to display it

changed title from Ğ1 license: give the choice on a workstation how to display it to Ğ1 license display on a workstation: give the choice how to display it

added Easy pick label

changed milestone to %0.10.0

marked this issue as related to #221 (closed)

marked this issue as related to #392 (closed)

I am not sure your report was about #392 (closed) since you said you had the issue with Poetry. Otherwise, that would explains your error.

mentioned in commit 82612c14