#213: Write unit tests for the transaction command

#213 (closed): Unit tests for tx.py. Create unit tests for:

• handle_intermediaries_transactions,
• send_transaction,
• generate_and_send_transaction,
• display_sent_tx,
• check_transaction_values,
• generate_unlocks,
• generate_output,

Modifies test for get_list_input_for_transaction,

Changes how patched_get_sources() works:

• create a dictionary for test sources.

Deals with other issues:

• Close #197: one test for auth_method()
• Close #282 (closed): split patched.py
• Close #335 (closed): two functions are testing transaction_amount()

changed milestone to %0.8.x

added Test label

changed the description

assigned to @moul and unassigned @matograine

mentioned in merge request !108 (merged)

changed milestone to %0.8.0

added D: Transfer label

mentioned in merge request !132 (merged)

mentioned in issue #323 (closed)

changed milestone to %0.9.0

mentioned in merge request !134 (closed)

changed the description

changed target branch from multiple_output_amounts to dev

With this firsts reviews fixed, I can approve the auth and tui parts.

Following steps would be to review the money and tx parts.

added 60 commits

• cab03a1d...ded4611a - 40 commits from branch dev
• 6abc9dcd - [enh] #140 (closed): wot: Add choose_identity()
• 07ffd290 - [mod] #140 (closed): Change argument name for better --help
• 94de11d5 - [dep] Introduce asynctest as dev dependency for Py < 3.8
• 190fa9d4 - [dep] #251 (closed): Add pendulum dependency
• 8d661407 - [feat] #88 (closed): Add membership command
• e6a4ff57 - [test] tx.transaction_amount: monkeypatch ud_value
• 07d9d690 - [dep] #338 (closed): Update black to v20.8b1
• 48e52f92 - [test] #307 (closed): Create test_tui.py file
• 8ddb1261 - [test] #282 (closed): split patched.py
• fec79c3a - [mod] #213 (closed): import whole modules in tx.py
• 03c52f0c - [test] #197: add test for auth_method()
• 5803775c - [test] #213 (closed): move useful test patched functions
• d7363465 - [test] #213 (closed): modify patched_get_source()
• d1edcfcd - [mod][test] cleaning tests/test_unit_tx.py
• e9b04e32 - [test] #213 (closed): create test for handle_intermediary_transaction()
• 08417228 - [test] #213 (closed): add test for send_transaction()
• e42b77f9 - [test] #213 (closed): create test for generate_and_send_transaction()
• 442a4117 - [mod] #213 (closed): change check_transaction_values
• cd613459 - [test] #213 (closed): create test for generate_unlocks
• 391b265f - [test] #213 (closed): create test for generate_output()

Compare with previous version

changed the description

added 16 commits

• 391b265f...863383c8 - 3 commits from branch dev
• 910f8b59 - [test] #307 (closed): Create test_tui.py file
• f9cb2d90 - [test] #282 (closed): split patched.py
• 196f2648 - [mod] #213 (closed): import whole modules in tx.py
• d7c2061f - [test] #197: add test for auth_method()
• 7225bbd3 - [test] #213 (closed): move useful test patched functions
• 81567c75 - [test] #213 (closed): modify patched_get_source()
• 0e770474 - [mod][test] cleaning tests/test_unit_tx.py
• 4fdb98dd - [test] #213 (closed): create test for handle_intermediary_transaction()
• 8e73b4b7 - [test] #213 (closed): add test for send_transaction()
• fc782308 - [test] #213 (closed): create test for generate_and_send_transaction()
• 3eefb1de - [mod] #213 (closed): change check_transaction_values
• 1f2807a4 - [test] #213 (closed): create test for generate_unlocks
• ff0e1a2e - [test] #213 (closed): create test for generate_output()

Compare with previous version

mentioned in merge request !143 (merged)

added 28 commits

• ff0e1a2e...c7e0069c - 3 commits from branch dev
• d9c94bf5 - [test] #307 (closed): Create test_tui.py file
• 3d81980a - [mod] #301 (closed) : create a function gen_checksum
• c919f8f7 - [mod] #320 (closed) #301 (closed) split check_public_key()
• 415d829b - [mod] #301 (closed) : create function display_pubkey_and_checksum()
• 4c0d3756 - [enh] #301 (closed) display the checksum in the tx command
• 8d33a488 - [enh] #301 (closed) : make `history` command use <pubkey:checksum> format
• a0e01ce9 - [enh] #301 (closed) make `balance` use <pubkey:checksum> format for display
• 9b9925c7 - [enh] #301 (closed) : make `wot` and `id` commands use <pubkey:checksum> format
• 3243e1e7 - [enh] #301 (closed) : make `cert` command use <pubkey:checksum> format
• d19bd261 - [enh] #301 (closed) : make `membership` command display <pubkey:checksum> format
• 803172d1 - [enh] #301 (closed) : make `authfile` command display <pubkey:checksum> format
• 64773a4d - [mod] Introduce has_auth_method() used in `balance`
• 6bd8bc87 - [enh] #301 (closed): Add checksum command
• b04b53dc - [test] #282 (closed): split patched.py
• 403e270d - [mod] #213 (closed): import whole modules in tx.py
• 366a4220 - [test] #197: add test for auth_method()
• 2a158ced - [test] #213 (closed): move useful test patched functions
• 8380fd5d - [test] #213 (closed): modify patched_get_source()
• 842eb173 - [mod][test] cleaning tests/test_unit_tx.py
• 4307e284 - [test] #213 (closed): create test for handle_intermediary_transaction()
• 9db03b5c - [test] #213 (closed): add test for send_transaction()
• 1284334b - [test] #213 (closed): create test for generate_and_send_transaction()
• 63e896d7 - [mod] #213 (closed): create test for check_transaction_values
• 72c5c5b4 - [test] #213 (closed): create test for generate_unlocks
• 138dd371 - [test] #213 (closed): create test for generate_output()

Compare with previous version

added 12 commits

• ae0b2a8c - [test] #282 (closed): split patched.py
• 3ea8858d - [mod] #213 (closed): import whole modules in tx.py
• 68c01758 - [test] #197: add test for auth_method()
• 516b4de6 - [test] #213 (closed): move useful test patched functions
• df270519 - [test] #213 (closed): modify patched_get_source()
• 2b9937ef - [mod][test] cleaning tests/test_unit_tx.py
• a091a711 - [test] #213 (closed): create test for handle_intermediary_transaction()
• f24da260 - [test] #213 (closed): add test for send_transaction()
• f63ff8e1 - [test] #213 (closed): create test for generate_and_send_transaction()
• c5ab43d1 - [mod] #213 (closed): create test for check_transaction_values
• fbf032ae - [test] #213 (closed): create test for generate_unlocks
• ad4b82e0 - [test] #213 (closed): create test for generate_output()

Compare with previous version

added 30 commits

• ad4b82e0...5c40d079 - 16 commits from branch dev
• 6a189d78 - [test] #282 (closed): split patched.py
• 1926423e - [mod] #213 (closed): import whole modules in tx.py
• f650e510 - [test] #197: add test for auth_method()
• 42656e70 - [test] #213 (closed): move useful test patched functions
• 85b0b5a5 - [test] #213 (closed): modify patched_get_source()
• 7ef811fa - [mod][test] cleaning tests/test_unit_tx.py
• ad7eb545 - [test] #335 (closed) : two functions are testing transaction_amount()
• ce3ae58f - [test] #213 (closed): create test for handle_intermediary_transaction()
• 099c5310 - [test] #213 (closed): add test for send_transaction()
• 978ee880 - [test] #213 (closed): create test for generate_and_send_transaction()
• 2f9b7fde - [mod] tx.py : use MAX_COMMENT_LENGTH as a constant for comment check
• 88c0cea0 - [mod] #213 (closed): create test for check_transaction_values
• 955b40d3 - [test] #213 (closed): create test for generate_unlocks
• 969ac9a9 - [test] #213 (closed): create test for generate_output()

Compare with previous version

changed the description

added 15 commits

• a7b8a0af - 1 commit from branch dev
• b42d665c - [test] #282 (closed): split patched.py
• 2d94030e - [mod] #213 (closed): import whole modules in tx.py
• 22db414d - [test] #197: add test for auth_method()
• bf83b7bf - [test] #213 (closed): move useful test patched functions
• fdee9f2c - [test] #213 (closed): modify patched_get_source()
• a601cc55 - [mod][test] cleaning tests/test_unit_tx.py
• 9cf9a45e - [test] #335 (closed) : two functions are testing transaction_amount()
• 0bba6936 - [test] #213 (closed): create test for handle_intermediary_transaction()
• cfc64276 - [test] #213 (closed): add test for send_transaction()
• dd287895 - [test] #213 (closed): create test for generate_and_send_transaction()
• e65e51dd - [mod] tx.py : use MAX_COMMENT_LENGTH as a constant for comment check
• e54f54f4 - [mod] #213 (closed): create test for check_transaction_values
• 6d92a5ba - [test] #213 (closed): create test for generate_unlocks
• 66dc6ec0 - [test] #213 (closed): create test for generate_output()

Compare with previous version

added 16 commits

• 805f3f44 - [test] #282 (closed): split patched.py
• 42fd87bd - [test] #213 (closed): use directly mock_ud_value instead of copying it to variables
• da38ccd6 - [mod] #213 (closed): import whole modules in tx.py
• 6c1423e6 - [test] #197: add test for auth_method()
• 9b210881 - [test] #213 (closed): move useful test patched functions
• 5b0c1c86 - [test] #213 (closed): modify patched_get_source()
• aea92415 - [mod][test] cleaning tests/test_unit_tx.py
• 8b4d0647 - [mod][test] make test_membership.py use fake_block_uid value
• 52293dbd - [test] #335 (closed) : two functions are testing transaction_amount()
• 222e6661 - [test] #213 (closed): create test for handle_intermediary_transaction()
• 1c4db0e2 - [test] #213 (closed): add test for send_transaction()
• 33589774 - [test] #213 (closed): create test for generate_and_send_transaction()
• 3bb4f486 - [mod] tx.py : use MAX_COMMENT_LENGTH as a constant for comment check
• 7a473382 - [mod] #213 (closed): create test for check_transaction_values
• 0bccf997 - [test] #213 (closed): create test for generate_unlocks
• dce2c5d8 - [test] #213 (closed): create test for generate_output()

Compare with previous version

added 16 commits

• 3fb16efd - [test] #282 (closed): split patched.py
• 461642d7 - [test] #213 (closed): use directly mock_ud_value instead of copying it to variables
• 1efd5a1b - [mod] #213 (closed): import whole modules in tx.py
• 53fa309f - [test] #197: add test for auth_method()
• 855080bb - [test] #213 (closed): move useful test patched functions
• 33ba7693 - [test] #213 (closed): modify patched_get_source()
• cd8ed333 - [mod][test] cleaning tests/test_unit_tx.py
• 60c1f6ee - [test] create fake_block_uid to mock a block uid.
• cb13f399 - [test] #335 (closed) : two functions are testing transaction_amount()
• 14318265 - [test] #213 (closed): create test for handle_intermediary_transaction()
• fa091752 - [test] #213 (closed): add test for send_transaction()
• 50ef7af6 - [test] #213 (closed): create test for generate_and_send_transaction()
• 616379c4 - [mod] tx.py : use MAX_COMMENT_LENGTH as a constant for comment check
• 2f2731b3 - [mod] #213 (closed): create test for check_transaction_values
• 58f9df9f - [test] #213 (closed): create test for generate_unlocks
• 6c4d8094 - [test] #213 (closed): create test for generate_output()

Compare with previous version

mentioned in merge request !154 (merged)

resolved all threads

Very clean commits, which make the review way easy. I appreciate it. Great work!

I quickly checked the big tests of the big functions. I trust you on that. And this is tests, this is not critical as the runtime code.

Let's move on and not block everything, we will improve/fix the tests when we will find things to improve.

approved this merge request

Thanks for your nice comment !

OK. I'll rebase it on the current dev, merge, then create tests for !154 (merged) (issue #362 (closed))

added 23 commits

• 6c4d8094...bda2b8cd - 7 commits from branch dev
• ab3ff0c6 - [test] #282 (closed): split patched.py
• 942259e6 - [test] #213 (closed): use directly mock_ud_value instead of copying it to variables
• d004c799 - [mod] #213 (closed): import whole modules in tx.py
• 9a353cea - [test] #197: add test for auth_method()
• 5031b5e9 - [test] #213 (closed): move useful test patched functions
• 78060fa5 - [test] #213 (closed): modify patched_get_source()
• 3e051e9f - [mod][test] cleaning tests/test_unit_tx.py
• ca5b662f - [test] create fake_block_uid to mock a block uid.
• 005b705d - [test] #335 (closed) : two functions are testing transaction_amount()
• a32e60ce - [test] #213 (closed): create test for handle_intermediary_transaction()
• 85fa5668 - [test] #213 (closed): add test for send_transaction()
• d0929b13 - [test] #213 (closed): create test for generate_and_send_transaction()
• 9edc0d2e - [mod] tx.py : use MAX_COMMENT_LENGTH as a constant for comment check
• 65377291 - [mod] #213 (closed): create test for check_transaction_values
• d612b73b - [test] #213 (closed): create test for generate_unlocks
• ae9b3b99 - [test] #213 (closed): create test for generate_output()

Compare with previous version

merged

mentioned in issue #197

changed title from #213 (closed): Transaction tests to #213 (closed): Write unit tests for the Transaction command