Skip to content
Snippets Groups Projects

#409: Improve endpoint determination code layer

Merged Moul requested to merge 409_determine_endpoint into dev
  • Implement determine_endpoint() to replace Endpoint()
  • It handles custom, default g1 and gtest endpoints
  • Read custom endpoints from a regex
  • Handle host/ipv4 mixup fix with ipaddress
  • ipv6 support with brackets

  • Rename peer to endpoint:
  • option --peer/-p −> --endpoint/-ep
  • import sys and silkaj.constants directly
  • write tests

Kept the ability of not having click installed

  • #354 The tests are difficult to write Actually, I am not sure if this feature is easy use. Using Silkaj as lib is kind of difficult since click is imported in almost every modules

  • Introduce click context helper

Close #181 (closed), #409 (closed).

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading