From 198d632784de926d136d8a438e577322ee31574b Mon Sep 17 00:00:00 2001 From: librelois <elois@ifee.fr> Date: Wed, 27 Jun 2018 18:32:06 +0200 Subject: [PATCH] [fix] inso reviews --- rfc/0006_ws2p_v2.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/rfc/0006_ws2p_v2.md b/rfc/0006_ws2p_v2.md index 3855e54..39f902d 100644 --- a/rfc/0006_ws2p_v2.md +++ b/rfc/0006_ws2p_v2.md @@ -263,13 +263,13 @@ WS2PFeatures type definition : |:---------:|-----------| | 0000_0001 | DEFLATE | | 0000_0010 | LOW | -| 0000_0100 | RBF | +| 0000_0100 | ABF | DEFLATE := Supports permessage-deflate extension LOW := Accept low speed connection requests -RBF := Accept rust binary format +ABF := Support all binary formats. WS2P v2 uses only 3 of 8 features. The 5 free bits can be used for future versions of WS2P. @@ -286,7 +286,7 @@ AF := API_FEATURE Example: - WS2P 2 S (DEFLATE LOW RBF) g1.durs.ifee.fr 443 ws2p + WS2P 2 S (DEFLATE LOW ABF) g1.durs.ifee.fr 443 ws2p Same endpoint in binary format : @@ -326,6 +326,8 @@ Signed document declaring all the endpoints of a peer. endpoints_datas := tuples table (endpoint_size, endpoint). +`endpoint_size` type : u16. + `endpoint` type is defined above (See "Endpoint format"). The document is represented by an array of bytes containing (peer_card_size + 2) bytes. @@ -378,10 +380,10 @@ If the outcoming quota is already reached at the beginning of an attempt, the le The WS2P module does not attempt to connect randomly to any node among those of which it knows a WS2P endpoint, it classifies them according to the following criteria : -### 1st criterion: the network layer +### 1st criterion: network features -If the node is configured to use an X network layer, then all nodes that accept a connection through this X network layer will have priority. -Currently, only the TOR network layer is implemented. +Some network features, imply that the node prioritizes endpoints having such or such network feature. +For example, if the node has the TOR feature, it will prioritize nodes that also have the TOR feature. _Note: the first criterion takes precedence over the second one._ @@ -551,7 +553,7 @@ Some WS2Pv1 messages are accepted within WS2Pv2 connections, here is the exhaust * v1 requests * responses to v1 requests -WARNING : Exception with the RBF api feature : In a WS2P connection between two nodes that both support RBF api feature, any WS2Pv1 message is rejected ! +WARNING : Exception with the ABF api feature : In a WS2P connection between two nodes that both support ABF api feature, any WS2Pv1 message is rejected ! ### REQUESTS @@ -744,7 +746,7 @@ There are still 5 flags for future network layers that could be implemented in t ### Documents messages -All WS2Pv2 documents are necessarily in RBF (Rust Binary Format). When document binarization is coded in Duniter-ts, then it will be necessary to define a common binary format for each document. For performance reasons, we will probably opt for the format in which each document is signed. +All WS2Pv2 documents are necessarily in Binary Format. When document binarization is coded in Duniter-ts, then it will be necessary to define a common binary format for each document. For performance reasons, we will probably opt for the format in which each document is signed. We must therefore wait for the binarization of the blockchain protocol. -- GitLab