From 099eded8fc050c9e1b41f4499fff68841a76e973 Mon Sep 17 00:00:00 2001
From: cgeek <cem.moreau@gmail.com>
Date: Tue, 30 May 2023 12:33:05 +0200
Subject: [PATCH] fix(!115): use value rather than references
---
pallets/duniter-wot/src/lib.rs | 11 +++++------
runtime/common/src/handlers.rs | 7 ++++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/pallets/duniter-wot/src/lib.rs b/pallets/duniter-wot/src/lib.rs
index 94a20b1b4..cf4aaf938 100644
--- a/pallets/duniter-wot/src/lib.rs
+++ b/pallets/duniter-wot/src/lib.rs
@@ -301,6 +301,7 @@ where
// implement identity event handler
impl<T: Config<I>, I: 'static> pallet_identity::traits::OnIdtyChange<T> for Pallet<T, I> {
fn on_idty_change(_idty_index: IdtyIndex, idty_event: &pallet_identity::Event<T>) -> Weight {
+ let idty_event: pallet_identity::Event<T> = (*idty_event).clone();
match idty_event {
pallet_identity::Event::IdtyCreated {
creator,
@@ -308,9 +309,7 @@ impl<T: Config<I>, I: 'static> pallet_identity::traits::OnIdtyChange<T> for Pall
idty_index,
} => {
if let Err(e) = <pallet_certification::Pallet<T, I>>::do_add_cert_checked(
- *creator,
- *idty_index,
- true,
+ creator, idty_index, true,
) {
sp_std::if_std! {
println!("fail to force add cert: {:?}", e)
@@ -319,14 +318,14 @@ impl<T: Config<I>, I: 'static> pallet_identity::traits::OnIdtyChange<T> for Pall
}
pallet_identity::Event::IdtyValidated { idty_index } => {
// auto claim membership on main wot
- <pallet_membership::Pallet<T, I>>::try_claim_membership(*idty_index);
+ <pallet_membership::Pallet<T, I>>::try_claim_membership(idty_index);
}
pallet_identity::Event::IdtyRemoved { idty_index, status } => {
- if *status != IdtyStatus::Validated {
+ if status != IdtyStatus::Validated {
if let Err(e) =
<pallet_certification::Pallet<T, I>>::remove_all_certs_received_by(
frame_system::Origin::<T>::Root.into(),
- *idty_index,
+ idty_index,
)
{
sp_std::if_std! {
diff --git a/runtime/common/src/handlers.rs b/runtime/common/src/handlers.rs
index 021db4e25..45cc8f433 100644
--- a/runtime/common/src/handlers.rs
+++ b/runtime/common/src/handlers.rs
@@ -45,6 +45,7 @@ where
T: pallet_universal_dividend::Config,
{
fn on_idty_change(_idty_index: IdtyIndex, idty_event: &pallet_identity::Event<T>) -> Weight {
+ let idty_event: pallet_identity::Event<T> = (*idty_event).clone();
match idty_event {
pallet_identity::Event::IdtyValidated { idty_index: _ } => {
// when identity is validated, it starts getting right to UD
@@ -55,8 +56,8 @@ where
new_owner_key,
} => {
if let Err(e) = pallet_authority_members::Pallet::<T>::change_owner_key(
- *idty_index,
- (*new_owner_key).clone(),
+ idty_index,
+ (new_owner_key).clone(),
) {
log::error!(
"on_idty_change: pallet_authority_members.change_owner_key(): {:?}",
@@ -67,7 +68,7 @@ where
pallet_identity::Event::IdtyCreated { .. }
| pallet_identity::Event::IdtyConfirmed { .. }
| pallet_identity::Event::IdtyRemoved { .. } => {}
- &_ => {} // TODO: why is it necessary?
+ _ => {} // TODO: why is it necessary?
}
Weight::zero()
}
--
GitLab