From 13c6b2c59d3ce2e6a611335cbfcfa4d6ce8e719a Mon Sep 17 00:00:00 2001
From: cgeek <cem.moreau@gmail.com>
Date: Tue, 23 Jan 2024 23:21:24 +0100
Subject: [PATCH] fix(#176): ExpiresOn is now correctly updated for Pending
smiths
---
pallets/smith-members/src/lib.rs | 2 +-
pallets/smith-members/src/tests.rs | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/pallets/smith-members/src/lib.rs b/pallets/smith-members/src/lib.rs
index 691e68e99..cce2dbaea 100644
--- a/pallets/smith-members/src/lib.rs
+++ b/pallets/smith-members/src/lib.rs
@@ -461,7 +461,7 @@ impl<T: Config> Pallet<T> {
let new_expires_on =
CurrentSession::<T>::get() + T::SmithInactivityMaxDuration::get();
smith_meta.expires_on = Some(new_expires_on);
- // ExpiresOn::<T>::append(new_expires_on, receiver);
+ ExpiresOn::<T>::append(new_expires_on, receiver);
}
// - if the status is smith but wasn't, notify that smith gained membership
diff --git a/pallets/smith-members/src/tests.rs b/pallets/smith-members/src/tests.rs
index 60a8786a1..a200d0551 100644
--- a/pallets/smith-members/src/tests.rs
+++ b/pallets/smith-members/src/tests.rs
@@ -594,7 +594,6 @@ fn certifying_an_online_smith() {
received_certs: vec![1, 2]
})
);
- // TODO: test is failing here because ExpiresOn is not correctly updated
assert_eq!(ExpiresOn::<Runtime>::get(7), Some(vec![5]));
Pallet::<Runtime>::on_smith_goes_online(5);
--
GitLab