From 2e3f12ecc19da8d2daf356323f0aba80ebfd90fa Mon Sep 17 00:00:00 2001
From: Hugo Trentesaux <hugo@trentesaux.fr>
Date: Sun, 29 May 2022 10:23:27 +0200
Subject: [PATCH] fix(cucumber) clippy and contributing
---
CONTRIBUTING.md | 4 +++-
end2end-tests/tests/common/cert.rs | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3c3134ec2..7f2fc29bb 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -31,7 +31,9 @@ Please read [Developer documentation] before contribute.
2. Ensure that you respect the [commit naming conventions].
-3. Ensure that all automated tests pass with the `npm test` command.
+3. Ensure that all automated tests pass with the `cargo test` command.
+
+3. Ensure that the code is well formated `cargo fmt` and comply with the good practices `cargo clippy`. If you have been working on tests, check everything with `cargo clippy --all --tests`.
4. Update the documentation with details of changes to the interface, this includes new environment
variables, exposed ports, useful file locations and container parameters.
diff --git a/end2end-tests/tests/common/cert.rs b/end2end-tests/tests/common/cert.rs
index 7a344e319..021dfa2ea 100644
--- a/end2end-tests/tests/common/cert.rs
+++ b/end2end-tests/tests/common/cert.rs
@@ -33,7 +33,7 @@ pub async fn certify(
client,
api.tx()
.cert()
- .add_cert(to.into())
+ .add_cert(to)
.create_signed(&from, ())
.await?,
)
--
GitLab