From 39ab7b7746db111bcf4c79ef5b25e6ed7fd3c0bd Mon Sep 17 00:00:00 2001
From: cgeek <cem.moreau@gmail.com>
Date: Thu, 14 Dec 2023 16:13:17 +0100
Subject: [PATCH] feat(smith-members): weird things
---
pallets/authority-members/src/lib.rs | 1 +
runtime/common/src/handlers.rs | 1 +
2 files changed, 2 insertions(+)
diff --git a/pallets/authority-members/src/lib.rs b/pallets/authority-members/src/lib.rs
index 78be54ef2..6bd4e6302 100644
--- a/pallets/authority-members/src/lib.rs
+++ b/pallets/authority-members/src/lib.rs
@@ -530,6 +530,7 @@ impl<T: Config> pallet_session::SessionManager<T::ValidatorId> for Pallet<T> {
let members_ids_to_add = IncomingAuthorities::<T>::take();
let members_ids_to_del = OutgoingAuthorities::<T>::take();
+ // TODO: what if we have outgoing members but no incoming ones?
if members_ids_to_add.is_empty() {
if members_ids_to_del.is_empty() {
// when no change to the set of autorities, return None
diff --git a/runtime/common/src/handlers.rs b/runtime/common/src/handlers.rs
index 8cb679c66..a8fbd18a5 100644
--- a/runtime/common/src/handlers.rs
+++ b/runtime/common/src/handlers.rs
@@ -95,6 +95,7 @@ impl<
// user will have to claim authority membership
}
sp_membership::Event::MembershipRemoved(idty_index) => {
+ // TODO: recursive call? (see authority-members -> revoke_membership)
let call = pallet_authority_members::Call::<Runtime>::remove_member {
member_id: *idty_index,
};
--
GitLab