From 771df7eff1fa55d24f4c2c3552da74c961767e80 Mon Sep 17 00:00:00 2001
From: bgallois <benjamin@gallois.cc>
Date: Mon, 29 May 2023 09:53:15 +0200
Subject: [PATCH] fix slashing strategy

---
 pallets/offences/src/lib.rs   |  2 +-
 pallets/offences/src/tests.rs | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/pallets/offences/src/lib.rs b/pallets/offences/src/lib.rs
index 3d7c119f8..02316c4f6 100644
--- a/pallets/offences/src/lib.rs
+++ b/pallets/offences/src/lib.rs
@@ -124,7 +124,7 @@ where
         };
 
         // Define the slash strategy.
-        let slash_strategy = if O::ID != *b"im-online:offlin" {
+        let slash_strategy = if O::ID == *b"im-online:offlin" {
             SlashStrategy::Disconnect
         } else {
             SlashStrategy::BlackList
diff --git a/pallets/offences/src/tests.rs b/pallets/offences/src/tests.rs
index 8b6d27958..1b5fefff8 100644
--- a/pallets/offences/src/tests.rs
+++ b/pallets/offences/src/tests.rs
@@ -37,6 +37,19 @@ fn should_report_an_authority_and_trigger_on_offence_and_add_to_blacklist() {
         Offences::report_offence(vec![], offence).unwrap();
 
         // then
+        assert_eq!(
+            offence_reports(KIND, time_slot),
+            vec![
+                OffenceDetails {
+                    offender: 5,
+                    reporters: vec![]
+                },
+                OffenceDetails {
+                    offender: 9,
+                    reporters: vec![]
+                }
+            ]
+        );
     });
 }
 
@@ -62,6 +75,13 @@ fn should_not_report_the_same_authority_twice_in_the_same_slot() {
         );
 
         // then
+        assert_eq!(
+            offence_reports(KIND, time_slot),
+            vec![OffenceDetails {
+                offender: 5,
+                reporters: vec![]
+            },]
+        );
     });
 }
 
-- 
GitLab