diff --git a/pallets/authority-members/src/lib.rs b/pallets/authority-members/src/lib.rs index 68f9aa998d4f55c289fa6978610f77a51273e362..7884482b31a30a650fc32aa341ef53a0b9a93f1e 100644 --- a/pallets/authority-members/src/lib.rs +++ b/pallets/authority-members/src/lib.rs @@ -299,7 +299,7 @@ pub mod pallet { let member_id = Self::verify_ownership_and_membership(&who)?; let _post_info = pallet_session::Call::<T>::set_keys { - keys: keys.into(), + keys, proof: vec![], } .dispatch_bypass_filter(origin)?; diff --git a/pallets/identity/src/benchmarking.rs b/pallets/identity/src/benchmarking.rs index c3df1b542ab9f1e567e652cb8f79039968e185c9..f8c2e2665adcc309f415569f7f96654b0fd8240d 100644 --- a/pallets/identity/src/benchmarking.rs +++ b/pallets/identity/src/benchmarking.rs @@ -87,7 +87,7 @@ fn create_dummy_identity<T: Config>(i: u32) -> Result<(), &'static str> { <Identities<T>>::insert(idty_index, value); IdentitiesRemovableOn::<T>::append(removable_on, (idty_index, IdtyStatus::Created)); IdentityIndexOf::<T>::insert(owner_key.clone(), idty_index); - <IdentitiesNames<T>>::insert(idty_name.clone(), ()); + <IdentitiesNames<T>>::insert(idty_name.clone(), idty_index); Ok(()) } diff --git a/pallets/membership/src/benchmarking.rs b/pallets/membership/src/benchmarking.rs index da0ce28b79f6aa29453b8b379843f268c982865c..11c95849efa4196bd17807b37e3fd6c377b68ae7 100644 --- a/pallets/membership/src/benchmarking.rs +++ b/pallets/membership/src/benchmarking.rs @@ -46,7 +46,7 @@ benchmarks_instance_pallet! { let caller: T::AccountId = T::AccountIdOf::convert(idty.clone()).unwrap(); let caller_origin: <T as frame_system::Config>::RuntimeOrigin = RawOrigin::Signed(caller.clone()).into(); // Lazily prepare call as this extrinsic will always return an errror when in subwot - let call = Call::<T, I>::request_membership { metadata: T::MetaData ::default()}; + let call = Call::<T, I>::request_membership { }; }: { call.dispatch_bypass_filter(caller_origin).ok(); } @@ -58,7 +58,7 @@ benchmarks_instance_pallet! { claim_membership { let idty: T::IdtyId = 3.into(); Membership::<T, I>::take(idty); - PendingMembership::<T, I>::insert(idty.clone(), T::MetaData::default()); + PendingMembership::<T, I>::insert(idty.clone(), ()); let caller: T::AccountId = T::AccountIdOf::convert(idty.clone()).unwrap(); let caller_origin: <T as frame_system::Config>::RuntimeOrigin = RawOrigin::Signed(caller.clone()).into(); T::BenchmarkSetupHandler::force_status_ok(&idty, &caller); diff --git a/pallets/membership/src/lib.rs b/pallets/membership/src/lib.rs index aa5ee14c53c73302835dd4cc403213a475bfa7a4..3855bf927d51cfb435f7bc9f6de0f0c6cc4a8bc4 100644 --- a/pallets/membership/src/lib.rs +++ b/pallets/membership/src/lib.rs @@ -356,7 +356,7 @@ pub mod pallet { /// perform membership claim fn do_claim_membership(idty_id: T::IdtyId) { - if let Some(_) = PendingMembership::<T, I>::take(idty_id) { + if PendingMembership::<T, I>::take(idty_id).is_some() { Self::insert_membership_and_schedule_expiry(idty_id); Self::deposit_event(Event::MembershipAcquired(idty_id)); T::OnEvent::on_event(&sp_membership::Event::MembershipAcquired(idty_id));