From 8f80c30e616805705c2568db9786cd88d9ee1833 Mon Sep 17 00:00:00 2001
From: bgallois <benjamin@gallois.cc>
Date: Thu, 21 Dec 2023 15:48:52 +0100
Subject: [PATCH] fix #166
---
pallets/membership/src/benchmarking.rs | 4 ++--
pallets/membership/src/lib.rs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/pallets/membership/src/benchmarking.rs b/pallets/membership/src/benchmarking.rs
index 531bd3e13..e3a028dbb 100644
--- a/pallets/membership/src/benchmarking.rs
+++ b/pallets/membership/src/benchmarking.rs
@@ -76,9 +76,9 @@ benchmarks_instance_pallet! {
}: {Pallet::<T, I>::on_initialize(BlockNumberFor::<T>::zero());}
expire_memberships {
- let i in 0..1024;
+ let i in 0..3; // Limited by the number of validators
let mut idties: Vec<T::IdtyId> = Vec::new();
- for j in 0..i {
+ for j in 1..i+1 {
let j: T::IdtyId = j.into();
Membership::<T, I>::insert(j, MembershipData::<T::BlockNumber>::default());
idties.push(j);
diff --git a/pallets/membership/src/lib.rs b/pallets/membership/src/lib.rs
index 284a03244..08bbb81ad 100644
--- a/pallets/membership/src/lib.rs
+++ b/pallets/membership/src/lib.rs
@@ -308,7 +308,7 @@ pub mod pallet {
for idty_id in MembershipsExpireOn::<T, I>::take(block_number) {
// remove membership (take)
Self::do_remove_membership(idty_id, MembershipRemovalReason::Expired);
- expired_idty_count = 0;
+ expired_idty_count += 1;
}
T::WeightInfo::expire_memberships(expired_idty_count)
}
--
GitLab