From c83e45a61786458e660504277757c174b5fbf646 Mon Sep 17 00:00:00 2001
From: cgeek <cem.moreau@gmail.com>
Date: Mon, 29 Jan 2024 13:07:37 +0100
Subject: [PATCH] review(#162): `identity_revokes_on` is more accurate

---
 node/src/chain_spec/gen_genesis_data.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/node/src/chain_spec/gen_genesis_data.rs b/node/src/chain_spec/gen_genesis_data.rs
index c0d547519..ba2609e03 100644
--- a/node/src/chain_spec/gen_genesis_data.rs
+++ b/node/src/chain_spec/gen_genesis_data.rs
@@ -201,7 +201,7 @@ struct IdentityV2 {
     /// block at which the membership is set to expire (0 for expired members)
     membership_expire_on: u32,
     /// block at which the identity should be revoked (value in the past for already revoked identities)
-    membership_revokes_on: u32,
+    identity_revokes_on: u32,
     /// whether the identity is revoked (manually or automatically)
     revoked: bool,
     /// block at which the next cert can be emitted
@@ -1288,7 +1288,7 @@ fn genesis_data_to_identities_v2(
                         i.membership_expire_on,
                         genesis_timestamp,
                     ),
-                    membership_revokes_on: timestamp_to_relative_blocs(
+                    identity_revokes_on: timestamp_to_relative_blocs(
                         i.membership_revokes_on,
                         genesis_timestamp,
                     ),
@@ -1334,7 +1334,7 @@ fn make_authority_exist<SessionKeys: Encode, SKP: SessionKeysProvider<SessionKey
                 balance: common_parameters.balances_existential_deposit,
                 certs_received: HashMap::new(),
                 membership_expire_on: common_parameters.membership_membership_period,
-                membership_revokes_on: common_parameters.identity_autorevocation_period,
+                identity_revokes_on: common_parameters.identity_autorevocation_period,
                 revoked: false,
                 next_cert_issuable_on: 0,
             },
@@ -1480,7 +1480,7 @@ fn feed_identities(
                 None
             },
             revokes_on: if status == IdtyStatus::NotMember {
-                Some(identity.membership_revokes_on)
+                Some(identity.identity_revokes_on)
             } else {
                 None
             },
-- 
GitLab