Non member genesis identities have right to UD

On gdev

identity.identities(3)
{
  data: {
    firstEligibleUd: 1
  }
  nextCreatableIdentityOn: 0
  oldOwnerKey: null
  ownerKey: 5FsCe2pAWBvt5ZXrpneyFsgqJppTP9XaE37Zh1ju1aJctRh8
  nextScheduled: 0
  status: Revoked
}

This revoked identity has right to UD.

This is because all genesis identities are initialized with IdtyData::new() no matter their status. Non-member identities must be initialized with IdtyData::default() so that their first_eligible_ud.0 is None.

changed milestone to %client-0.10.0

added Mandatory-prod P2-asap bug labels

mentioned in merge request !299 (merged)

I would remove new or default. If the arguments passed to new don't fully determine the returned struct, then new should be equivalent to default or it makes no sense.

And having multiple methods for the same thing may be good for convenience libraries, which is not the case here, so it would be better to remove one of them than to make them equivalent.

Edit: if something requires it to impl Default, then new could just be renamed with an explicit name.

Pour aller dans le sens de tuxmain, pourquoi est-ce que IdtyData::new() set automatiquement le firstEligibleUd à 1 au lieu de None ?

e6be6a09

mentioned in merge request !297 (merged)

added genesis label

assigned to @tuxmain

added S-doing label

mentioned in merge request !304 (merged)

closed with merge request !304 (merged)