Skip to content
Snippets Groups Projects

refac add_cert

Merged Hugo Trentesaux requested to merge hugo-dev into master
All threads resolved!

Yesterday while working on duniter-squid I found these improvements to Duniter. Some should be discussed first.

Addresses #177 (closed), #178 (closed), #179 (closed)

Edited by Hugo Trentesaux

Merge request reports

Merge request pipeline #35705 passed

Merge request pipeline passed for c96987ce

Approved by

Merged by Hugo TrentesauxHugo Trentesaux 1 year ago (Jan 29, 2024 2:23pm UTC)

Merge details

Pipeline #35706 passed

Pipeline passed for 629c5b9d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hugo Trentesaux
  • Hugo Trentesaux
  • Hugo Trentesaux added 1 commit

    added 1 commit

    Compare with previous version

  • Hugo Trentesaux added 2 commits

    added 2 commits

    Compare with previous version

  • Hugo Trentesaux changed title from Draft: clean up errors to Draft: pack of minor improvements

    changed title from Draft: clean up errors to Draft: pack of minor improvements

  • Hugo Trentesaux changed the description

    changed the description

  • Hugo Trentesaux added 1 commit

    added 1 commit

    Compare with previous version

  • Hugo Trentesaux requested review from @pokapow

    requested review from @pokapow

  • Hugo Trentesaux added 1 commit

    added 1 commit

    • 2e870a2c - fix benchmarks also with true runtime

    Compare with previous version

  • Hugo Trentesaux added 1 commit

    added 1 commit

    Compare with previous version

  • Hugo Trentesaux added 1 commit

    added 1 commit

    • 42fe270f - I do not know why these tests did not run locally

    Compare with previous version

  • Hugo Trentesaux added 10 commits

    added 10 commits

    Compare with previous version

  • Hugo Trentesaux changed title from Draft: pack of minor improvements to Draft: refac add_cert

    changed title from Draft: pack of minor improvements to Draft: refac add_cert

  • Hugo Trentesaux
  • Hugo Trentesaux added 10 commits

    added 10 commits

    Compare with previous version

  • poka
  • poka
  • poka
  • poka
  • poka
    • Resolved by poka

      Voilà pour ma revue, je mettrais 7/10, pour l'effort. Merci de prendre en considération mes remarques pertinentes.

  • Hugo Trentesaux added 1 commit

    added 1 commit

    Compare with previous version

  • poka
  • Hugo Trentesaux added 1 commit

    added 1 commit

    Compare with previous version

  • Hugo Trentesaux added 13 commits

    added 13 commits

    Compare with previous version

  • Hugo Trentesaux marked this merge request as ready

    marked this merge request as ready

  • Hugo Trentesaux enabled an automatic merge when the pipeline for c96987ce succeeds

    enabled an automatic merge when the pipeline for c96987ce succeeds

  • Hugo Trentesaux resolved all threads

    resolved all threads

  • poka approved this merge request

    approved this merge request

  • poka resolved all threads

    resolved all threads

  • Hugo Trentesaux mentioned in commit 629c5b9d

    mentioned in commit 629c5b9d

  • mentioned in issue #179 (closed)

  • Please register or sign in to reply
    Loading