From 41c20c9c5068731dd7df029311d4fd183e56b585 Mon Sep 17 00:00:00 2001 From: cgeek <cem.moreau@gmail.com> Date: Sat, 9 May 2020 15:27:25 +0200 Subject: [PATCH 1/2] [fix] #1409: expensive method no more used by duniter-ui --- app/lib/dal/indexDAL/leveldb/LevelDBBlockchain.ts | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/app/lib/dal/indexDAL/leveldb/LevelDBBlockchain.ts b/app/lib/dal/indexDAL/leveldb/LevelDBBlockchain.ts index ffcefc147..03a9dc5e6 100644 --- a/app/lib/dal/indexDAL/leveldb/LevelDBBlockchain.ts +++ b/app/lib/dal/indexDAL/leveldb/LevelDBBlockchain.ts @@ -245,17 +245,6 @@ export class LevelDBBlockchain extends LevelDBTable<DBBlock> return theLast; } - // TODO: Unused? potentially costly because of full scan - async lastBlockWithDividend(): Promise<DBBlock | null> { - let theLast: DBBlock | null = null; - await this.readAllKeyValue((kv) => { - if (!theLast && kv.value.dividend) { - theLast = kv.value; - } - }); - return theLast; - } - async removeBlock(blockstamp: string): Promise<void> { await this.del(LevelDBBlockchain.trimKey(parseInt(blockstamp))); } -- GitLab From be08c404e3716a54a91fb8182ca4bbb6e590c73a Mon Sep 17 00:00:00 2001 From: cgeek <cem.moreau@gmail.com> Date: Sat, 9 May 2020 16:20:45 +0200 Subject: [PATCH 2/2] [fix] #1409: missing interface removal --- app/lib/dal/indexDAL/abstract/BlockchainDAO.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/lib/dal/indexDAL/abstract/BlockchainDAO.ts b/app/lib/dal/indexDAL/abstract/BlockchainDAO.ts index cbc15a3ff..def236f36 100644 --- a/app/lib/dal/indexDAL/abstract/BlockchainDAO.ts +++ b/app/lib/dal/indexDAL/abstract/BlockchainDAO.ts @@ -15,8 +15,6 @@ export interface BlockchainDAO extends GenericDAO<DBBlock>, ForksDAO { lastBlockOfIssuer(issuer: string): Promise<DBBlock | null>; - lastBlockWithDividend(): Promise<DBBlock | null>; - getCountOfBlocksIssuedBy(issuer: string): Promise<number>; dropNonForkBlocksAbove(number: number): Promise<void>; -- GitLab