duniter issueshttps://git.duniter.org/nodes/typescript/duniter/-/issues2023-06-12T12:56:27+02:00https://git.duniter.org/nodes/typescript/duniter/-/issues/1446Reverting a block that consumed a source can delete the source, in SINDEX sub...2023-06-12T12:56:27+02:00Benoit LavenierReverting a block that consumed a source can delete the source, in SINDEX sub-index (indexForConditions)This unit test failed "revert b#3-4 and re-commit block#3 should be ok"
Cause:
- In [`LevelDBSindex.removeBlock()`](https://git.duniter.org/nodes/typescript/duniter/-/blob/dev/app/lib/dal/indexDAL/leveldb/LevelDBSindex.ts#L313) (for re...This unit test failed "revert b#3-4 and re-commit block#3 should be ok"
Cause:
- In [`LevelDBSindex.removeBlock()`](https://git.duniter.org/nodes/typescript/duniter/-/blob/dev/app/lib/dal/indexDAL/leveldb/LevelDBSindex.ts#L313) (for reverting a block), we call `trimConditions()` when a consumption is undone (when the `UPDATE` record should be deleted) even if a source creation exists.
Solution:
- The correct approach would be to call `trimConditions()` only when no source creation exists anymore.Cédric MoreauCédric Moreauhttps://git.duniter.org/nodes/typescript/duniter/-/issues/1445Synchronize on BMAS enpoint with a path (e.g. `/bma`)2023-06-06T18:02:11+02:00Benoit LavenierSynchronize on BMAS enpoint with a path (e.g. `/bma`)Yunohost Duniter package deploy BMAS on path `/bma`. Such endpoints seems to be not used by `sync` commandYunohost Duniter package deploy BMAS on path `/bma`. Such endpoints seems to be not used by `sync` commandhttps://git.duniter.org/nodes/typescript/duniter/-/issues/1335Have command specific options2019-01-29T12:17:41+01:00MoulHave command specific optionscf https://www.npmjs.com/package/commander#command-specific-options
This is really annoying to find which option apply to which command.
There is some specifics option only for `sync` command for instance.
They should only be accessib...cf https://www.npmjs.com/package/commander#command-specific-options
This is really annoying to find which option apply to which command.
There is some specifics option only for `sync` command for instance.
They should only be accessible via `duniter sync -h` and not via `duniter -h`.
General options which can apply to many commands should stay at the root of the help.2.0https://git.duniter.org/nodes/typescript/duniter/-/issues/1329WS2P sync does not work on nodes with a path in their WS2P endpoint2020-10-04T18:34:41+02:00Cédric MoreauWS2P sync does not work on nodes with a path in their WS2P endpointFor example with this endpoint:
WS2P 90e9b12 duniter.g1.1000i100.fr 443 /ws2p
Duniter will try to join `wss://duniter.g1.1000i100.fr /ws2p`. There is an extra space here which make the connection fail.For example with this endpoint:
WS2P 90e9b12 duniter.g1.1000i100.fr 443 /ws2p
Duniter will try to join `wss://duniter.g1.1000i100.fr /ws2p`. There is an extra space here which make the connection fail.1.10Cédric MoreauCédric Moreau