[fix] #1350 Time of transactions not being saved on SQLite table

added 1 commit

5353612d - [fix] #1350 (closed) Time of transactions not being saved on SQLite table

Compare with previous version

mentioned in issue #1350 (closed)

added 19 commits

5353612d...14074533 - 18 commits from branch nodes/typescript:dev
c55d3370 - [fix] #1350 (closed) Time of transactions not being saved on SQLite table

Compare with previous version

changed milestone to %1.7

assigned to @c-geek

For information the node on g1.presles.fr is using a 1.7.14 version of Duniter with the fix of this merge request included (and synced from g1.le-sou.org (1.6.30)). I configured it as a mirror for now so it can be used with a client correctly (as it's running on a Raspberry Pi 3, calculating blocks makes it hard to use with a client (too slow in that case) like Cesium).

You can use it to test and compare with other Duniter 1.7 (and 1.6 also) nodes in a client like Cesium to see the effect of this very small fix ;).

mentioned in issue #1340 (closed)

added 1 commit

6b8195ef - Added integration tests for transaction history and transaction history with times filters

Compare with previous version

I've added integration tests so that regressions on history with times filters will be detected in the future.

removed assignee

assigned to @moul

Very nice contribution!

The fix and the tests looks good. I tested it and it works as expected.

Unfortunately CI doesn’t work. It is only set for this repository.

I imported your branch and two commits in the repository.

And the CI pipeline succeed!

And, btw, I am not able to sync on your node:

Status: CANNOT_CONNECT_TO_REMOTE_FOR_SYNC
All done.
2019-04-02T23:56:09+02:00 - info: Block resolution: 0 potential blocks for root block...
2019-04-02T23:56:09+02:00 - info: Connecting to address g1.presles.fr :443...
2019-04-02T23:56:28+02:00 - error: Error: CANNOT_CONNECT_TO_REMOTE_FOR_SYNC
    at Function.getSyncAPI (/home/moul/duniter/app/modules/crawler/lib/sync/RemoteSynchronizer.js:136:19)
    at <anonymous>

curl g1.presles.fr:443
<html>
<head><title>400 The plain HTTP request was sent to HTTPS port</title></head>
<body>
<center><h1>400 Bad Request</h1></center>
<center>The plain HTTP request was sent to HTTPS port</center>
<hr><center>nginx</center>
</body>
</html>

I synced on g1.le-sou.org:80.

I propose to merge this and make a release 1.7.15.

It's probably because I was adjusting the configuration of the node's new host machine, I migrated it to an Intel NUC Core i5 based computer this evening.

You should be able to sync on it now.

enabled an automatic merge when the pipeline for 6b8195ef succeeds

canceled the automatic merge

merged

mentioned in commit 541335a3

mentioned in issue #1331 (closed)

[fix] #1350 Time of transactions not being saved on SQLite table

Merge request reports

Activity