From a3d487308abb2fe08aef018ac333581c47a2d855 Mon Sep 17 00:00:00 2001 From: cgeek <cem.moreau@gmail.com> Date: Wed, 14 Jun 2017 11:09:24 +0200 Subject: [PATCH] [fix] Install modules through a POST HTTP request instead of GET --- app/js/services/webmin.js | 4 ++-- server/controller/webmin.js | 4 ++-- server/lib/routes.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/js/services/webmin.js b/app/js/services/webmin.js index 24a3730..49e485b 100644 --- a/app/js/services/webmin.js +++ b/app/js/services/webmin.js @@ -181,8 +181,8 @@ module.exports = (angular) => { uiModules: getResource('/webmin/plug/ui_modules'), uiGetMenuInjection: (moduleName) => getResource('/webmin/plug/ui_modules/inject/' + moduleName)(), checkAccess: getResource('/webmin/plug/check_access'), - addPackage: (pkg) => getResource('/webmin/plug/add/' + encodeURIComponent(pkg), null, 60000)(), - removePackage: (pkg) => getResource('/webmin/plug/rem/' + encodeURIComponent(pkg))() + addPackage: (pkg) => postResource('/webmin/plug/add/')({ pkg }), + removePackage: (pkg) => postResource('/webmin/plug/rem/')({ pkg }) } } } diff --git a/server/controller/webmin.js b/server/controller/webmin.js index b9f6a13..90a203a 100644 --- a/server/controller/webmin.js +++ b/server/controller/webmin.js @@ -595,7 +595,7 @@ function WebAdmin (duniterServer, startServices, stopServices, listDuniterUIPlug }) this.plugAdd = (req) => co(function*() { - const module = req.params.package + const module = req.body.pkg if (module.match(/^file:/)) { const resolvedPath = path.resolve(module.replace('file:', '')) const installed = listDuniterUIPlugins() @@ -614,7 +614,7 @@ function WebAdmin (duniterServer, startServices, stopServices, listDuniterUIPlug }) this.plugRemove = (req) => co(function*() { - const module = req.params.package + const module = req.body.pkg yield requirePlugin().duniter.methods.npmRemove(module, null, path.resolve('./')) return true }) diff --git a/server/lib/routes.js b/server/lib/routes.js index 1b7bf01..66b97b5 100644 --- a/server/lib/routes.js +++ b/server/lib/routes.js @@ -39,8 +39,8 @@ module.exports = { handleRequest(app.get.bind(app), '/webmin/plug/ui_modules', webminCtrl.plugUiModulesList); handleRequest(app.get.bind(app), '/webmin/plug/ui_modules/inject/:package', webminCtrl.plugUiModulesGetInjection); handleRequest(app.get.bind(app), '/webmin/plug/check_access', webminCtrl.plugCheckAccess); - handleRequest(app.get.bind(app), '/webmin/plug/add/:package', webminCtrl.plugAdd); - handleRequest(app.get.bind(app), '/webmin/plug/rem/:package', webminCtrl.plugRemove); + handleRequest(app.post.bind(app), '/webmin/plug/add', webminCtrl.plugAdd); + handleRequest(app.post.bind(app), '/webmin/plug/rem', webminCtrl.plugRemove); handleFileRequest(app.get.bind(app),'/webmin/data/duniter_export', webminCtrl.exportData); handleRequest(app.post.bind(app), '/webmin/data/duniter_import', webminCtrl.importData); }, -- GitLab