Fix weight for handlers (!212)

* fix weight for handlers

pallets/authority-members/src/lib.rs

@@ -405,7 +405,7 @@ pub mod pallet {
 
             // Emit event
             Self::deposit_event(Event::MemberRemoved { member: member_id });
-            let _ = T::OnRemovedMember::on_removed_member(member_id);
+            T::OnRemovedMember::on_removed_member(member_id);
         }
         /// perform incoming authorities insertion
         fn insert_in(member_id: T::MemberId) -> bool {

pallets/authority-members/src/traits.rs

@@ -15,24 +15,19 @@
 // along with Duniter-v2S. If not, see <https://www.gnu.org/licenses/>.
 
 use super::SessionIndex;
-use frame_support::pallet_prelude::Weight;
 
 pub trait OnNewSession {
-    fn on_new_session(index: SessionIndex) -> Weight;
+    fn on_new_session(index: SessionIndex);
 }
 
 impl OnNewSession for () {
-    fn on_new_session(_: SessionIndex) -> Weight {
-        Weight::zero()
-    }
+    fn on_new_session(_: SessionIndex) {}
 }
 
 pub trait OnRemovedMember<MemberId> {
-    fn on_removed_member(member_id: MemberId) -> Weight;
+    fn on_removed_member(member_id: MemberId);
 }
 
 impl<MemberId> OnRemovedMember<MemberId> for () {
-    fn on_removed_member(_: MemberId) -> Weight {
-        Weight::zero()
-    }
+    fn on_removed_member(_: MemberId) {}
 }

pallets/distance/src/lib.rs

@@ -461,7 +461,7 @@ pub mod pallet {
     }
 
     impl<T: Config> pallet_authority_members::OnNewSession for Pallet<T> {
-        fn on_new_session(index: SessionIndex) -> Weight {
+        fn on_new_session(index: SessionIndex) {
             EvaluationBlock::<T>::set(frame_system::Pallet::<T>::parent_hash());
 
             // Make results expire
@@ -505,7 +505,6 @@ pub mod pallet {
                     );
                 }
             }
-            Weight::zero()
         }
     }
 

runtime/common/src/handlers.rs

@@ -29,9 +29,9 @@ impl<Runtime> pallet_authority_members::traits::OnNewSession for OnNewSessionHan
 where
     Runtime: pallet_provide_randomness::Config + pallet_distance::Config,
 {
-    fn on_new_session(index: sp_staking::SessionIndex) -> Weight {
+    fn on_new_session(index: sp_staking::SessionIndex) {
         pallet_provide_randomness::Pallet::<Runtime>::on_new_epoch();
-        pallet_distance::Pallet::<Runtime>::on_new_session(index)
+        pallet_distance::Pallet::<Runtime>::on_new_session(index);
     }
 }
 
@@ -154,11 +154,9 @@ impl<Runtime> pallet_authority_members::traits::OnRemovedMember<IdtyIndex>
 where
     Runtime: frame_system::Config + pallet_membership::Config<Instance2, IdtyId = IdtyIndex>,
 {
-    fn on_removed_member(idty_index: IdtyIndex) -> Weight {
+    fn on_removed_member(idty_index: IdtyIndex) {
         // TODO investigate why we should remove smith membership when removing authority member
         pallet_membership::Pallet::<Runtime, Instance2>::force_revoke_membership(idty_index);
-        // TODO investigate why weight zero
-        Weight::zero()
     }
 }