refact: public and secret copy

src/crypto/duniter_key.rs

@@ -8,10 +8,13 @@ use scrypt::password_hash::{Output, PasswordHasher, SaltString};
 
 use crate::crypto::duniter_signature::DuniterSignature;
 
+const PUBLIC_KEY_LEN: usize = 32;
+const SECRET_KEY_LEN: usize = 64;
+
 /// The main functional class for handle Duniter crypto.
 pub struct DuniterKey {
-    pub public: [u8; 32],
-    pub secret: [u8; 64],
+    pub public: [u8; PUBLIC_KEY_LEN],
+    pub secret: [u8; SECRET_KEY_LEN],
 }
 
 /// How to display a duniter keyring: "pub_base58:sec_base58" format.
@@ -32,18 +35,10 @@ impl DuniterKey {
     pub fn from_base58(public: &str, secret: &str) -> Result<DuniterKey, Box<dyn Error>> {
         let public_vec = bs58::decode(public).into_vec().unwrap();
         let secret_vec = bs58::decode(secret).into_vec().unwrap();
-        let mut public = [0u8; 32];
-        for (i, v) in public_vec.iter().enumerate() {
-            if i < 32 {
-                public[i] = *v;
-            }
-        }
-        let mut secret = [0u8; 64];
-        for (i, v) in secret_vec.iter().enumerate() {
-            if i < 64 {
-                secret[i] = *v;
-            }
-        }
+        let mut public = [0u8; PUBLIC_KEY_LEN];
+        let mut secret = [0u8; SECRET_KEY_LEN];
+        for i in 0..PUBLIC_KEY_LEN { public[i] = public_vec[i] }
+        for i in 0..SECRET_KEY_LEN { secret[i] = secret_vec[i] }
         Ok(DuniterKey { public, secret })
     }