[mod] __eq__(): return NotImplemented in case of equality between different classes

duniterpy/api/endpoint.py

@@ -108,10 +108,9 @@ class UnknownEndpoint(Endpoint):
         return "{0} {1}".format(self.api, ' '.join(["{0}".format(p) for p in self.properties]))
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, UnknownEndpoint):
+        if not isinstance(other, UnknownEndpoint):
+            return NotImplemented
         return self.api == other.api and self.properties == other.properties
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((self.api, self.properties))
@@ -204,11 +203,10 @@ class BMAEndpoint(Endpoint):
         return self.inline()
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, BMAEndpoint):
+        if not isinstance(other, BMAEndpoint):
+            return NotImplemented
         return self.server == other.server and self.ipv4 == other.ipv4 \
                    and self.ipv6 == other.ipv6 and self.port == other.port
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((self.server, self.ipv4, self.ipv6, self.port))
@@ -347,11 +345,10 @@ class WS2PEndpoint(Endpoint):
         return self.inline()
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, WS2PEndpoint):
+        if not isinstance(other, WS2PEndpoint):
+            return NotImplemented
         return self.server == other.server and self.ws2pid == other.ws2pid \
                    and self.port == other.port and self.path == other.path
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((self.ws2pid, self.server, self.port, self.path))
@@ -409,10 +406,9 @@ class ESCoreEndpoint(Endpoint):
         return self.inline()
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, ESCoreEndpoint):
+        if not isinstance(other, ESCoreEndpoint):
+            return NotImplemented
         return self.server == other.server and self.port == other.port
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((self.server, self.port))
@@ -470,10 +466,9 @@ class ESUserEndpoint(Endpoint):
         return self.inline()
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, ESUserEndpoint):
+        if not isinstance(other, ESUserEndpoint):
+            return NotImplemented
         return self.server == other.server and self.port == other.port
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((self.server, self.port))
@@ -531,10 +526,9 @@ class ESSubscribtionEndpoint(Endpoint):
         return self.inline()
 
     def __eq__(self, other: Any) -> bool:
-        if isinstance(other, ESSubscribtionEndpoint):
+        if not isinstance(other, ESSubscribtionEndpoint):
+            return NotImplemented
         return self.server == other.server and self.port == other.port
-        else:
-            return False
 
     def __hash__(self) -> int:
         return hash((ESSubscribtionEndpoint.API, self.server, self.port))

duniterpy/documents/block.py

@@ -501,7 +501,7 @@ Nonce: {nonce}
 
     def __eq__(self, other: object) -> bool:
         if not isinstance(other, Block):
-            return False
+            return NotImplemented
         return self.blockUID == other.blockUID
 
     def __lt__(self, other: object) -> bool:

duniterpy/documents/block_uid.py

@@ -51,7 +51,7 @@ class BlockUID:
 
     def __eq__(self, other: object) -> bool:
         if not isinstance(other, BlockUID):
-            return False
+            return NotImplemented
         return self.number == other.number and self.sha_hash == other.sha_hash
 
     def __lt__(self, other: object) -> bool: