Stop using the Makefile in the CI and tools installed from Poetry dev dependencies in favor of pre-commit

• Delete dev dependencies tools from pyproject.toml: black, pylint, mypy, pre-commit?
  • Since the dependencies are duplicated in Poetry and Pre-commit virtualenvs.
• Document how to use dependencies installed into pre-commit: pre-commit run black -a.
• CI: Run tools without the make rule call
  • pytest to be merged
  • Update sphinx doc to not requires make dependency to build the doc
    • Remove make installation from image generations
• Update the Makefile in favour of pre-commit run -a (${tool}) calls
  • Readme: change make commands with poetry, pre-commit, sphinx* commands

changed milestone to %1.0.0

added CI/CD Dep Dev Env Documentation labels

changed the description

marked this issue as related to #162 (closed)

mentioned in merge request !136 (merged)

mentioned in commit ad2612b6

mentioned in commit d8ff1c71

mentioned in commit c398fb47

mentioned in commit 4ce02207

mentioned in commit 3ae5e157

mentioned in commit d1dcfb87

@vtexier's !136 (comment 28495):

I need to see how it integrate within the Pycharm workflow. Because I fear to not see exactly what goes wrong in a hook in Pycharm, rather than the make command in the terminal. I see that Pre-commit commands ran manually are more complex than make commands (options needed). And it worries me.

pre-commit hooks can run into the terminal in Pycharm. We can keep the Makefile, I still find some parts of it convenient.

changed the description

I have just tested the pre-commit with a mypy error when committing in Pycharm. All logs are in the Git Console window! This is great cause I have all the info to fix errors.

For the MakeFile, as you say we should not have two environments and replace poetry commands by pre-commit ones. To ensure using the same versions of utilities in pre-commit and make commands.

Before:

# check code errors
pylint:
	poetry run pylint duniterpy tests examples

After:

# check code errors
pylint:
	pre-commit run pylint duniterpy tests examples

changed title from Get rid of the makefile in favor of pre-commit to Get rid of the tools from Poetry dev dependencies in favor of pre-commit

changed the description

changed title from Get rid of the tools from Poetry dev dependencies in favor of pre-commit to Get rid of the Makefile and tools installed from Poetry dev dependencies in favor of pre-commit

changed the description

mentioned in commit 0719b34c

mentioned in commit 5a32d9c1

changed milestone to %Backlog

changed milestone to %1.1.0

marked this issue as related to #177 (closed)

marked the checklist item Delete dev dependencies tools from pyproject.toml: black, pylint, mypy, pre-commit? as completed

changed the description

changed the description

mentioned in commit 5965f5c0

mentioned in commit 4c366152

mentioned in commit b67abf4e

mentioned in commit f9199cc4

mentioned in commit 2f896265

mentioned in commit a38f3348

marked the checklist item Delete the Makefile in favour of pre-commit run -a (${tool}) call as completed

mentioned in merge request !170 (merged)

marked the checklist item Readme: change make commands with poetry, pre-commit, sphinx* commands as completed

mentioned in commit docker/python3/poetry@5c2746b7

mentioned in merge request docker/python3/poetry!3 (merged)

marked the checklist item Remove make installation from image generations as completed

changed title from Get rid of the Makefile and tools installed from Poetry dev dependencies in favor of pre-commit to Stop using the Makefile in the CI and tools installed from Poetry dev dependencies in favor of pre-commit

changed the description

mentioned in commit e637b82e

mentioned in commit 078871a7

closed with merge request !170 (merged)