Add support for Python v3.13

changed due date to October 01, 2024

added CI/CD Dev Env Test labels

marked this issue as related to #196 (closed)

mentioned in issue silkaj#482 (closed)

mentioned in issue #196 (closed)

marked this issue as related to docker/python3/poetry#10 (closed)

marked this issue as related to silkaj#482 (closed)

changed milestone to %1.3.0

changed the description

changed due date to October 07, 2024

assigned to @moul

marked the checklist item Set up v3.13 test job as completed

marked the checklist item With allow_failure: true, to allow tests to fail as completed

marked the checklist item Remove allow_failure: true, now on the tests should pass as completed

marked the checklist item Handle deprecation warning and breaking features as completed

changed the description

marked this issue as related to #212

mentioned in commit 72834fdc

mentioned in merge request !198 (merged)

closed with merge request !198 (merged)

marked the checklist item Handle deprecation warning and breaking features as incomplete

unassigned @moul

Actually, we have an annoying error message/raise with Python 3.13.

Exception ignored in: <http.client.HTTPResponse object at 0x7fbe7b6cf700>
Traceback (most recent call last):
  File "/usr/lib64/python3.13/http/client.py", line 432, in close
    super().close() # set "closed" flag
  File "/usr/lib64/python3.13/http/client.py", line 445, in flush
    self.fp.flush()
ValueError: I/O operation on closed file.

Can be reproduced in a Py3.13 container with request_data example for instance.

No idea where lies the issue. http.client, urllib.request.

http.client (3.12) http.client (3.13). This part of the code did not change. This is probably DuniterPy implementation which is wrong.

It looks like, the client is closed, then Python tries to close it, but then fails. After debugging, it seems to happen after API.request_url()’s return and after Client.get() calls it. Something is closing the file-descriptor, then Python 3.13 also tries to close it.

reopened

The following seems to be the reason why it started to happen with Py3.13:

Not sure how to fix it yet. That’s how urllib3 fixed it.

assigned to @moul

I found the root cause! According to io.IOBase.close, if the file (descriptor) is accessed after being close, ValueError is raised. The fd is copied (copy.copy). Both gets automatically closed once the function ends, the second can’t close a second time the same fd, that’s why we get this error. We have this implementation following these commits: ab7d01db (copy of fd) e14417d6 (The original fd was closed but no longer with with keyword usage).

marked the checklist item Handle deprecation warning and breaking features as completed

mentioned in commit 8d7c2d60

mentioned in merge request !199 (merged)

changed milestone to %1.2.1

marked this issue as related to #213

mentioned in commit 013486f5

mentioned in commit e10b2425

closed with merge request !199 (merged)

Add support for Python v3.13

Python pre-releases

Python stable release

Post

References

Child items ...

Activity