Skip to content
Snippets Groups Projects

Drop default asynchronous property

Merged Vincent Texier requested to merge remove_asyncio into dev
All threads resolved!

Stop aiohttp and asyncio usage.

Close #140 (closed).

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Things look good. I checked all the commits, except the first commit one since it is a bit tough to review. I will check it in detail later.

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Moul resolved all threads

    resolved all threads

  • Moul
  • Vincent Texier added 14 commits

    added 14 commits

    Compare with previous version

  • Vincent Texier added 1 commit

    added 1 commit

    Compare with previous version

  • Vincent Texier added 24 commits

    added 24 commits

    Compare with previous version

  • Vincent Texier added 20 commits

    added 20 commits

    Compare with previous version

  • Vincent Texier added 5 commits

    added 5 commits

    Compare with previous version

  • Moul requested review from @moul

    requested review from @moul

  • Moul assigned to @moul and unassigned @vtexier

    assigned to @moul and unassigned @vtexier

  • Moul resolved all threads

    resolved all threads

  • Feel free to assign it to me and set me as a reviewer when you want a review.

  • Put you as a reviewer seems normal to me.

    But why give you the assignement to merge the request ? I do not get the point here.

  • It means it's my turn to work on it.

    If after my review, I found something you have to fix, I would send the assignment back to you.

    Do you get the review process?

    Edited by Moul
  • No, I don't get it.

    I think your workflow doesn't reflect who do what.

    In fact, you just review, make comments, and I work on it, I fix and commit. You do not work on it.

    I prefer we keep the assignee field to the person who create, work on, or is assigned to merge a MR. Not to the reviewer. It is more clear.

  • Vincent Texier assigned to @vtexier and unassigned @moul

    assigned to @vtexier and unassigned @moul

  • Moul
  • Moul
  • Moul
  • Moul
  • Moul
  • Vincent Texier added 7 commits

    added 7 commits

    Compare with previous version

  • Vincent Texier added 5 commits

    added 5 commits

    Compare with previous version

  • Moul
  • Looks good to me. Great work!

    I would have merged piece by piece the last commit into the others. But, let's say that's fine.

  • Moul approved this merge request

    approved this merge request

  • Vincent Texier added 5 commits

    added 5 commits

    Compare with previous version

  • Moul
  • Vincent Texier added 6 commits

    added 6 commits

    Compare with previous version

  • I have merged the last commit in the respective ones. Thanks to point that out.

  • Moul resolved all threads

    resolved all threads

  • This is an important branch, and I you have seen problems after approval. I think everything is solved now. Can you confirm that I can merge ?

  • Thanks for asking. Yes, approved. It can be merged.

  • Pipeline job fails when installing black dependency.

    This is a problem with poetry.

    $ poetry install
    Creating virtualenv duniterpy-nwtWMc4E-py3.8 in /root/.cache/pypoetry/virtualenvs
    Updating dependencies
    Resolving dependencies...
      PackageNotFound
      Package black (20.8b1) not found.
      at /usr/local/lib/python3.8/site-packages/poetry/repositories/pool.py:144 in package
          140│                     self._packages.append(package)
          141│ 
          142│                     return package
          143│ 
        → 144│         raise PackageNotFound("Package {} ({}) not found.".format(name, version))
          145│ 
          146│     def find_packages(
          147│         self, dependency,
          148│     ):

    Locally, I have a failure also, but with sphinx dependency!

    (.venv) vit@K72Jr:~/Documents/dev/python/duniter-python-api$ poetry update
    Updating dependencies
    Resolving dependencies... (0.3s)
    
      PackageNotFound
    
      Package sphinx (3.5.3) not found.
    
      at ~/.poetry/lib/poetry/repositories/pool.py:144 in package
          140│                     self._packages.append(package)
          141│ 
          142│                     return package
          143│ 
        → 144│         raise PackageNotFound("Package {} ({}) not found.".format(name, version))
          145│ 
          146│     def find_packages(
          147│         self, dependency,
          148│     ):

    When upgrading sphinx with pip, it works fine:

    $ pip install --upgrade sphinx
    Installing collected packages: sphinx
      Attempting uninstall: sphinx
        Found existing installation: Sphinx 3.5.2
        Uninstalling Sphinx-3.5.2:
          Successfully uninstalled Sphinx-3.5.2
    Successfully installed sphinx-3.5.3

    My local version of poetry is Poetry version 1.1.4

    After upgrade to Poetry version 1.1.5 with poetry self update, I have the same problem...

    Any idea ?

  • Moul mentioned in issue #153 (closed)

    mentioned in issue #153 (closed)

  • Moul added BBC label

    added BBC label

  • Moul changed title from Remove aiohttp and asyncio to Drop default asynchronous property

    changed title from Remove aiohttp and asyncio to Drop default asynchronous property

  • Moul changed the description

    changed the description

  • Please register or sign in to reply
    Loading