Drop default asynchronous property

Stop aiohttp and asyncio usage.

Close #140 (closed).

changed milestone to %1.0.0

added Dep enhancement labels

added 1 commit

• f7376080 - [enh] #140 (closed) remove aiohttp from dependencies

Compare with previous version

added 4 commits

• 2166bb90 - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 1b646b1a - [enh] #140 (closed) remove asyncio and aiohttp in examples
• fd3153aa - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 7b6d599e - [enh] #140 (closed) remove aiohttp from dependencies

Compare with previous version

added 4 commits

• b48df4aa - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 23340456 - [enh] #140 (closed) remove asyncio and aiohttp in examples
• cea97b8b - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 4a07786e - [enh] #140 (closed) remove aiohttp from dependencies

Compare with previous version

added 3 commits

• 7173fb41 - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 985adefd - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 2aa6306a - [enh] #140 (closed) remove aiohttp from dependencies

Compare with previous version

changed the description

added Network label

mentioned in issue #140 (closed)

Things look good. I checked all the commits, except the first commit one since it is a bit tough to review. I will check it in detail later.

added 1 commit

• ed23b46e - [enh] #140 (closed) update dependencies in README.md

Compare with previous version

resolved all threads

added 14 commits

• ed23b46e...9eb69728 - 7 commits from branch dev
• acdc2d6e - [enh] #140 (closed) replace aiohttp requests with urllib and websocket clients
• 61b31970 - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 2a25d46b - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 893f60eb - [enh] #140 (closed) remove asyncio and aiohttp in tests
• b93bd5cb - [enh] #140 (closed) remove aiohttp from dependencies
• e95336b2 - [enh] #140 (closed) update dependencies in README.md
• 3a995790 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

added 1 commit

• e0f198d0 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

added 24 commits

• e0f198d0...54d860b0 - 17 commits from branch dev
• 92535fbf - [enh] #140 (closed) replace aiohttp requests with urllib and websocket clients
• 09f25bdd - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 8e1367fc - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 884fe9a5 - [enh] #140 (closed) remove asyncio and aiohttp in tests
• e0a14dff - [enh] #140 (closed) remove aiohttp from dependencies
• f369881e - [enh] #140 (closed) update dependencies in README.md
• 0191f922 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

added 20 commits

• 0191f922...f64174b1 - 13 commits from branch dev
• cc3fb54e - [enh] #140 (closed) replace aiohttp requests with urllib and websocket clients
• 20e1b5b4 - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 7e87ac07 - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 328bb1a7 - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 7c0875ff - [enh] #140 (closed) remove aiohttp from dependencies
• b22e5e88 - [enh] #140 (closed) update dependencies in README.md
• 52cd2623 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

added 5 commits

• 2da60b3a - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 729dbb84 - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 839acbad - [enh] #140 (closed) remove aiohttp from dependencies
• c593c349 - [enh] #140 (closed) update dependencies in README.md
• 5aad2059 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

requested review from @moul

assigned to @moul and unassigned @vtexier

resolved all threads

Feel free to assign it to me and set me as a reviewer when you want a review.

Put you as a reviewer seems normal to me.

But why give you the assignement to merge the request ? I do not get the point here.

It means it's my turn to work on it.

If after my review, I found something you have to fix, I would send the assignment back to you.

Do you get the review process?

No, I don't get it.

I think your workflow doesn't reflect who do what.

In fact, you just review, make comments, and I work on it, I fix and commit. You do not work on it.

I prefer we keep the assignee field to the person who create, work on, or is assigned to merge a MR. Not to the reviewer. It is more clear.

assigned to @vtexier and unassigned @moul

added 7 commits

• ac73dab7 - [enh] #140 (closed) replace aiohttp requests with urllib and websocket clients
• 56efc2d6 - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• ce577b74 - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 690c6fe5 - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 5c221754 - [enh] #140 (closed) remove aiohttp from dependencies
• 4ea0a310 - [enh] #140 (closed) update dependencies in README.md
• 2a5c0081 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

added 5 commits

• ba0f5a7c - [enh] #140 (closed) remove asyncio and aiohttp in examples
• 98d04d5c - [enh] #140 (closed) remove asyncio and aiohttp in tests
• e3737e80 - [enh] #140 (closed) remove aiohttp from dependencies
• 321b8fe8 - [enh] #140 (closed) update dependencies in README.md
• ee700e20 - [fix] #140 (closed) fix errors after merge resolve conflicts

Compare with previous version

Looks good to me. Great work!

I would have merged piece by piece the last commit into the others. But, let's say that's fine.

approved this merge request

added 5 commits

• 71866ef0 - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• dc668a85 - [enh] #140 (closed) remove asyncio and aiohttp in examples
• c5607ca3 - [enh] #140 (closed) remove asyncio and aiohttp in tests
• b5f5482b - [enh] #140 (closed) remove aiohttp from dependencies
• b666f86e - [enh] #140 (closed) update dependencies in README.md

Compare with previous version

added 6 commits

• 9cbc7dac - [enh] #140 (closed) replace aiohttp requests with urllib and websocket clients
• ab7d01db - [enh] #140 (closed) remove asyncio and aiohttp in duniterpy
• 64cd696a - [enh] #140 (closed) remove asyncio and aiohttp in examples
• f7d2654d - [enh] #140 (closed) remove asyncio and aiohttp in tests
• 8fb39d47 - [enh] #140 (closed) remove aiohttp from dependencies
• cb345a26 - [enh] #140 (closed) update dependencies in README.md

Compare with previous version

I have merged the last commit in the respective ones. Thanks to point that out.

resolved all threads

This is an important branch, and I you have seen problems after approval. I think everything is solved now. Can you confirm that I can merge ?

Thanks for asking. Yes, approved. It can be merged.

merged

Pipeline job fails when installing black dependency.

This is a problem with poetry.

$ poetry install
Creating virtualenv duniterpy-nwtWMc4E-py3.8 in /root/.cache/pypoetry/virtualenvs
Updating dependencies
Resolving dependencies...
  PackageNotFound
  Package black (20.8b1) not found.
  at /usr/local/lib/python3.8/site-packages/poetry/repositories/pool.py:144 in package
      140│                     self._packages.append(package)
      141│ 
      142│                     return package
      143│ 
    → 144│         raise PackageNotFound("Package {} ({}) not found.".format(name, version))
      145│ 
      146│     def find_packages(
      147│         self, dependency,
      148│     ):

Locally, I have a failure also, but with sphinx dependency!

(.venv) vit@K72Jr:~/Documents/dev/python/duniter-python-api$ poetry update
Updating dependencies
Resolving dependencies... (0.3s)

  PackageNotFound

  Package sphinx (3.5.3) not found.

  at ~/.poetry/lib/poetry/repositories/pool.py:144 in package
      140│                     self._packages.append(package)
      141│ 
      142│                     return package
      143│ 
    → 144│         raise PackageNotFound("Package {} ({}) not found.".format(name, version))
      145│ 
      146│     def find_packages(
      147│         self, dependency,
      148│     ):

When upgrading sphinx with pip, it works fine:

$ pip install --upgrade sphinx
Installing collected packages: sphinx
  Attempting uninstall: sphinx
    Found existing installation: Sphinx 3.5.2
    Uninstalling Sphinx-3.5.2:
      Successfully uninstalled Sphinx-3.5.2
Successfully installed sphinx-3.5.3

My local version of poetry is Poetry version 1.1.4

After upgrade to Poetry version 1.1.5 with poetry self update, I have the same problem...

Any idea ?

mentioned in issue #153 (closed)

added BBC label

changed title from Remove aiohttp and asyncio to Drop default asynchronous property

changed the description