Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • DuniterPy DuniterPy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • clientsclients
  • pythonpython
  • DuniterPyDuniterPy
  • Merge requests
  • !144

#95, #172: BBC: Arguments changes on 'Documents' constructors: Remove 'signature', introduce 'signing_key', make 'currency' and 'version' optionals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vincent Texier requested to merge document_init_refactor into dev Jun 13, 2021
  • Overview 98
  • Commits 9
  • Pipelines 33
  • Changes 30

Break backward compatibilities!

  • Remove useless signature argument from Documents.__init__()
    • Rename Identity(ts: BlockUID) by Identity(timestamp: BlockUID)
  • Refactor Document.signatures (List) as Document.signature (str)
    • Transaction can have multiple signatures, with Transaction.signatures attribute and Transaction.multi_sign([keys]) method.
    • Move signatures verifications in the Documents classes
  • Add optional signing_key argument in Document sub-classes
  • Refactor subclass version argument as optional with default=subclass.VERSION
  • Set time argument optional in SimpleTransaction
  • Refactor Documents currency arguments as optional with default=constants.CURRENCY_CODENAME_G1

Close #95 (closed), #172 (closed).

Edited Jun 18, 2021 by Moul
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: document_init_refactor