Skip to content
Snippets Groups Projects

Several transaction enhancements, other improvements

Merged Moul requested to merge transaction into dev

v0.54.0

Code/tests

  • Fix OutputSource and InputSource from_inline() regex matching
  • Transaction document: tests and code: drop versions 2 and 3 management
  • Block document: code: drop vensions 2 and 3 management
  • Block document: Upgrade blocks to v11 and TX to v10
  • Add OutputSource.inline_condition() method

Other

  • CI: Do not trigger build, tests, type check on modification of non-relevant files
  • Makefile: use python3 module to run tests and type check
  • Add coveralls as dev dependency
  • setup.py: add classifiers: Python versions, Intended Audience
  • Add CHANGELOG.md from v0.53.1

Open thoughts

  • Do we remove version handling for Input.from_inline() and Input.inline()?
    • It is not used by Sakia, so no breaking change.
    • For future version of transaction document, I don’t see any evolution of the input format.
    • For a practical usage, it is cleaner without having to specify the version
    • The decision is taken. I just share my thoughts here

Ah, and for your information, all the steps of the pipeline did succeed.

I updated last commit which now does not trigger pipeline steps. Unfortunately, the results are no longer displayed.

At least the trigger part works :wink:

Edited by Moul

Merge request reports

Pipeline #5328 passed

Pipeline passed for 4db793ba on transaction

Merged by Vincent TexierVincent Texier 6 years ago (Apr 28, 2019 2:02pm UTC)

Loading

Pipeline #5330 passed

Pipeline passed for 676b1099 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading