Black
- Add black as dev dependency
- Add black in
Makefile
(check-format
andformat
commands) - All files formatted with black
- Add check
format
stage in gitlab-ci - Move
push_to_github
stage inrelease
manual stage, after release to pip
Merge request reports
Activity
changed milestone to %0.54.x
added ~352 enhancement labels
added 1 commit
- 7a846b43 - [enh] #54 (closed) upgrade gitlab ci to python 3.6.8 for black check
added 1 commit
- d9f725a5 - [fix] #54 (closed) fix gitlab ci to install python 3.6.8 with pyenv
added 1 commit
- dfcafd74 - [fix] #54 (closed) fix gitlab ci to use pyenv python 3.6.4 already installed in the docker image
Do we keep Python 3.5 compatibility with this MR?
I assume it is clear that we want to keep it for the sake of having the larger Python versions compatibility for DuniterPy and Silkaj.
Of course, the Docker environment for Black to run, needs Python 3.6, because of Black requirement.
May we remove the
Py ≥ 3.6
badge?
I am sorry, but you will have to rebase on
dev
as my commits in this branch aren’t the same as indev
because of the date and the hash.Edited by MoulFor now, this merge request will not be ready until
pylint
has been accepted in thedev
branch. Then I will rebase theblack
branch on thedev
branch, resolving conflicts.I will revert the gitlab-ci to 3.5.5 and create an isolated first job only with
black/python 3.6.x
as there is afmt
job before anything else indurs
pipeline.So for this MR, we just have to wait till I declare it ready to review and merge.
added 24 commits
-
dfcafd74...31659fe7 - 21 commits from branch
dev
- 680e64a9 - [enh] #54 (closed) add black as dev dependency and in MakeFile (check and black commands)
- b9f17779 - [enh] #54 (closed) format code with "make black" command
- 698f804b - [enh] #54 (closed) add black stage in gitlab-ci (python 3.6.4 is used only in this stage)
Toggle commit list-
dfcafd74...31659fe7 - 21 commits from branch
added 1 commit
- f9339f63 - [enh] #54 (closed) add black stage in gitlab-ci (python 3.6.4 is used only in this stage)
added 1 commit
- 75cfeec3 - [enh] #54 (closed) add black stage in gitlab-ci (python 3.6.4 is used only in this stage)
added 1 commit
- f6aba29a - [enh] #54 (closed) add black stage in gitlab-ci (python 3.6.4 is used only in this stage)
added 1 commit
- 4da1456f - [enh] #54 (closed) add black stage in gitlab-ci
I leave the 3.6.x badge as it is required for the development environment now.
On the other hand, the gitlab-ci uses python 3.5.5 as default interpreter, and only switch to 3.6.4 for black install or run. So,
black
andcheck
stages are in python 3.6.4 and others are in python 3.5.5.Validation required.
Edited by Mouladded 1 commit
- bd1e0a7b - [enh] #54 (closed) add Python 3.6.x requirement in README
added 1 commit
- d1f8a4a6 - [enh] #54 (closed) improve gitlab ci (github after release, build used by release)
assigned to @moul