Pylint
- add missing bma.ws2p.heads request
- add Pylint as dependency
- add Pylint in MakeFile (pylint and check commands)
- fix all pylint alerts by fixing the code or disable the alert
Merge request reports
Activity
changed milestone to %0.54.x
added enhancement label
added 22 commits
-
705b304c...877a4f52 - 4 commits from branch
dev
- 6c4d7425 - [enh] refactor request api.ws2p.heads in api.bma.network.ws2p_heads
- eb994ca6 - [enh] #91 (closed) add pylint check
- 3195ca05 - [enh] #91 (closed) fix pylint alerts in api.bma.network module
- 04a581ff - [enh] #91 (closed) fix pylint alerts in api.client module
- 7283e43d - [enh] #91 (closed) fix pylint alerts in api.endpoint module
- e06f9d13 - [enh] #91 (closed) fix pylint alerts in documents.block_uid module
- ec55b8fb - [enh] #91 (closed) fix pylint alerts in documents.document module
- 8d3fdfe3 - [enh] #91 (closed) fix pylint alerts in documents.certification module
- a011bf12 - [enh] #91 (closed) fix pylint alerts in documents.ws2p.heads module
- e32b6943 - [enh] #91 (closed) fix pylint alerts in documents.transaction module
- e74df1a8 - [enh] #91 (closed) fix pylint alerts in documents.block module
- 8b2344f2 - [enh] #91 (closed) fix pylint alerts in key.base58 module
- e7d2fe1a - [enh] #91 (closed) fix pylint alerts in key.ascii_armor module
- b31fee74 - [enh] #91 (closed) fix pylint alerts in key.signing_key module
- 18ef68da - [fix] #91 (closed) fix bugs that broke tests
- 6be955a8 - [enh] #91 (closed) fix code to comply with mypy and pylint
- 2f1c50c1 - [fix] fix test_transaction
- 680fc5cb - [enh] #92 (closed) rename gitlab ci job "mypy" to "check" and run "make check"
Toggle commit list-
705b304c...877a4f52 - 4 commits from branch
Fixed, now branch pylint is rebased in a clean straight line from dev.
See https://git.duniter.org/clients/python/duniterpy/network/master
Edited by Vincent TexierFrom a reading point of view, it looks ok.
Documents
I am just afraid about the modifications of indexes into the
Block
and theTransaction
documents. Are they covered by tests? Yes, as you fixed bugs about that. But, may be not entirely.Pipeline
I checked with a local makefile that if one of the two steps in the
check
(mypy
orpylint
) fails, the jobs fails, because of the makefile targets mechanism.NotImplemented
And, to be consistent, we could change this one: https://git.duniter.org/clients/python/duniterpy/blob/master/duniterpy/api/endpoint.py#L56
I have made some smoke tests with Silkaj and this modifications.
It is good for me, you can merge it.
added 1 commit
- 6e190911 - [fix] Endpoint: replace NotImplementedError by NotImplemented in __eq__
-
NotImplemented fixed in Endpoint class.
-
I agree that indexes are frightening to change, so I will check Wednesday, and add/verify tests before merging if necessary… Thanks for having it tested in Silkaj.
-
Its normal for the pipeline, the check command failed at any errors. Doesn't bother me so far. Usage will say if we stay like that or not.
Edited by Moul-
- Test on block from_signed_raw cover the index change and is very secure, cause it convert back to signed_raw and compare :
https://git.duniter.org/clients/python/duniterpy/blob/dev/tests/documents/test_block.py#L400
- The transactions are also well covered. I am confident that nothing is broken from the index change.
As you have already validated this branch, I merge into dev.
mentioned in commit 31659fe7
changed milestone to %0.55.x
added Dep label