Fix tests in wheel

• Fix tests package installed with duniterpy package in wheel
• So we have an unattribued "tests" package installed, but not listed by Pypi. Weird.

changed milestone to %0.55.x

added 1 commit

• ae4c01dd - [fix] #98 (closed) fix coverage test command line in gitlab-ci

Compare with previous version

added 2 commits

• 430e37ea - [fix] #98 (closed) fix coverage test command line in gitlab-ci
• 834382c4 - [fix] #98 (closed) fix build and dist clear if folders not exists

Compare with previous version

added 1 commit

• eb0512d0 - [fix] #98 (closed) fix gitlab-ci and MakeFile bugs

Compare with previous version

@moul, ready to review...

changed the description

changed target branch from dev to pep_561_mypy

I changed the targeted branch for easier review.

But, you should use dev branch as a base of your MR not an other open MR.

Because, if we change something into mypy_pep_NNN branch, this one won’t be accurate anymore.

Could you please rewrite the history of your work, that way I can easily review it.

Accidentally removing something then adding something shouldn’t be my work to review.

I like to have a clean history which makes sense. To be able later to answer why did we made this change.

And use atomic commits, which clearly explains the changes, what have been fixes, changed, and how.

---

Why did you move tests folder into duniterpy? Wasn’t previous repository organisation correct? Cf Poetry doc.

What was your goal with that? Excluding it from PiPy publication? Make no sense.

Could you clearly split into separate commits/MR the changes about removing tests from the wheel distribution and the coverage fix which has a distinct ticket #90 (closed).

That would be great.

Thank you.

added 1 commit

• ec6dff7d - [fix] #98 (closed) fix tests folder included and installed with duniterpy package

Compare with previous version

changed target branch from pep_561_mypy to dev

added 1 commit

• d9e3dc48 - [fix] #98 (closed) fix gitlab-ci tests task

Compare with previous version

changed the description

Branch reduced and rebased on dev. Thanks for pushing me to be perfect ;-)

It make no sense (but may be I am wrong) to discover a "tests" package when we do a pip uninstall...

So I explained where I find the recommended way to place the tests folder in the issue.

But you are right, Python sometimes works in mysterious ways. We have to investigate more on this. Let's discuss that on the issue, with examples.

To put the tests folder in the package is a mistake, you're right! Silly me! I was too focused on follow a recommended architecture and forgot my objective : do not have the tests folder in the wheel.

New clean branch and merge request created. Closing this one.

closed