Skip to content
Snippets Groups Projects

Merge of pypi_test_deploy to dev

Closed Vincent Texier requested to merge pypi_test_deploy into dev
All threads resolved!
  • Add make commands to build, deploy and deploy_test
  • Add deploy_test in gitlab-ci
  • Add new env var PYPI_TEST_PASSWORD in gitlab settings
  • Improve README
Edited by Vincent Texier

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul
  • This one commit was hard to review as it changes too many things at the same time. There is: Move the inheritance for PyPI and PyPi test to the job itself, move the build command from a hidden job to a Makefile rule, and usage of (after_script) for the GitHub job. Plus change of documentation of all this.

    It would have been great to split this commit for easy review. It is hard read the changes and disentangle what changed.

    I know it is annoying to change the history. You could have create an other branch, and copy/paste changes and commit cleanly in an atomic way. For instance:

    • Use after_script for GitHub sync job
    • Create deploy and deploy_test Make rules + doc
    • Move PyPi and PyPi test inherited blocks to the jobs it-selves.
    • Create build rule in the Makefile + doc
    • Use make build into the CI

    And also, squash the commits fixes into those commits.


    Approved if you don’t want to rework the history.

    Edited by Moul
  • Vincent Texier changed the description

    changed the description

  • Vincent Texier added 13 commits

    added 13 commits

    Compare with previous version

  • I do not want to redo the history, but arf, let's do it. I will push another branch in another MR. Hope I will not break what is already working...

  • Moul resolved all discussions

    resolved all discussions

  • Vincent Texier mentioned in merge request !74 (merged)

    mentioned in merge request !74 (merged)

  • closed

  • Please register or sign in to reply
    Loading