Fix identity lookup going in infinite loop

src/cutecoin/core/registry/identities.py

@@ -45,11 +45,10 @@ class IdentitiesRegistry:
         return {'registry': identities_json}
 
     @asyncio.coroutine
-    def future_find(self, pubkey, community):
-        def lookup():
-            nonlocal identity
+    def _find_by_lookup(self, pubkey, community):
+        identity = self._instances[pubkey]
         lookup_tries = 0
-            while lookup_tries < 3 and identity.local_state == LocalState.NOT_FOUND:
+        while lookup_tries < 3:
             try:
                 data = yield from community.bma_access.simple_request(bma.wot.Lookup,
                                                             req_args={'search': pubkey})
@@ -65,6 +64,7 @@ class IdentitiesRegistry:
                                 identity.uid = identity_uid
                                 identity.blockchain_state = BlockchainState.BUFFERED
                                 identity.local_state = LocalState.PARTIAL
+                return identity
                 logging.debug("Lookup : found {0}".format(identity))
             except ValueError as e:
                 lookup_tries += 1
@@ -74,7 +74,10 @@ class IdentitiesRegistry:
                 lookup_tries += 1
             except NoPeerAvailable:
                 return identity
+        return identity
 
+    @asyncio.coroutine
+    def future_find(self, pubkey, community):
         if pubkey in self._instances:
             identity = self._instances[pubkey]
         else:
@@ -89,7 +92,7 @@ class IdentitiesRegistry:
                     identity.blockchain_state = BlockchainState.VALIDATED
                 except ValueError as e:
                     if '404' in str(e) or '400' in str(e):
-                        yield from lookup()
+                        identity = yield from self._find_by_lookup(pubkey, community)
                         return identity
                     else:
                         tries += 1