#385: Refactor id/lookup command using exclusively /wot/lookup

• Display non-member uids when passing a pubkey
• Use same algorithm as choose_identity() uses
  • Will display multiple time the pubkey and the differents uids if there is multiple uids linked to this pubkey
• The uids were already in /wot/lookup/
• Remove identity_of() call which can only get member uids
• Rename pubkey(s) to lookup(s)
• When passing a uid, use /wot/lookup/ instead of identity_of() which only gets member uids
• Rename variable, rename command description
• Use f-string, use one click.echo() call
• Rename id command to lookup:
  • Makes more sense and the identity cmd is about to be created

Will be cherry-pick to 0.9 branch and released if v0.9.0 in no additional rc is required.

Close #385 (closed).

changed milestone to %0.9.0

added Web of Trust enhancement labels

changed the description

added 1 commit

• 0488e6e8 - [fix] #385 (closed): id: Display non-member uids

Compare with previous version

changed the description

changed the description

There is something incoherent. Research is case-sensitive for members, but not for willmembers:

silkaj id Titi
Public keys found matching 'Titi':

→ 4qJZFRfArLaUMEXDhsd69unsKynEFNLFazAVij4HNsBa:F4z ↔ laetitia97421
→ 49nWdTQqDT8qpazzPeP6NH92NwppG7YEh6PFYC2VecNA:Ba6 ↔ titix
→ 435eaXjfQMeYB2f38UiqAuzH5KVU74jDZubGNMGDL7gL:831 ↔ Titi31
→ BRu1ExYTGEQJKWKnfkMnfHxhrVFdLYPdrbCPiGtmQEbu:G7N ↔ Titie

laetitia97421 and titix are willmembers.
If you don't plan to solve this here, you might create an issue.

changed title from #385 (closed): id: Display non-member uids to #385 (closed): Refactor id command using exclusively /wot/lookup

changed the description

Regarding the Titi thing, this is a BMA issue. Let's address it in GVA if encountered.

---

This change is becoming too big to enter a RC since we say we wanted to freeze the code. Though it should be safe to introduce this change in v0.9.0. It also bring something valuable. This could also be the occasion to write tests for this command. Should we release this change in v0.9.0 or in v0.10.0?

I was thinking about renaming this command to lookup since it's exclusively using /wot/lookup and it makes more sense than id. What do you think?

added 1 commit

• 95df1dbb - #385 (closed): Refactor id command using exclusively /wot/lookup:

Compare with previous version

resolved all threads

approved this merge request

assigned to @moul and unassigned @matograine

unapproved this merge request

changed title from #385 (closed): Refactor id command using exclusively /wot/lookup to #385 (closed): Refactor id/lookup command using exclusively /wot/lookup

changed the description