Skip to content
Snippets Groups Projects

Bump black to v21.4b2 and allow to install as pre-release

Merged Moul requested to merge black_21.4 into dev

otherwise it's not working without the poetry.lock

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul changed milestone to %0.10.0

    changed milestone to %0.10.0

  • Moul added Dep label

    added Dep label

  • Moul requested review from @moul and removed review request for @matograine

    requested review from @moul and removed review request for @matograine

  • Moul assigned to @moul and unassigned @matograine

    assigned to @moul and unassigned @matograine

  • Moul enabled an automatic merge when the pipeline for 58c3cf87 succeeds

    enabled an automatic merge when the pipeline for 58c3cf87 succeeds

  • merged

  • @moul I get errors during tests right after this commit.

    subprocess.CalledProcessError: Command '['poetry', 'run', 'silkaj', '--gtest', 'balance', '3dnbnYY9i2bHMQUGyFp5GVvJ2wBkVpus31cDJA5cfRpj']' returned non-zero exit status 1.
    
    ...
    
    Results (5.75s):
         167 passed
           4 failed
             - tests/test_end_to_end.py:23 test_info
             - tests/test_end_to_end.py:30 test_wot
             - tests/test_end_to_end.py:41 test_id
             - tests/test_end_to_end.py:48 test_balance
    
    

    edit - seems to be a local issue :-(

    pytest output is here (for reference, I won't investigate today): https://git.duniter.org/clients/python/silkaj/-/snippets/574

    error is:

    stdout = b"\n[RuntimeError]\nThe Poetry configuration is invalid:\n  - [dev-dependencies.black] {'version': '^21.4b2', 'allow-prereleases': True} is not valid under any of the given schemas\n\n"

    however, the right version is installed:

    # in poetry shell
    $ black --version
    black, version 21.4b2
    Edited by matograine
  • Author Owner

    Which poetry version do you run?

  • outside shell:

    $ poetry --version
    Poetry version 1.1.6

    inside poetry shell (same result before and after the last commit):

    $ poetry --version
    /home/thomas/.cache/pypoetry/virtualenvs/silkaj-aMRjPcbt-py3.7/bin/python3: No module named poetry
  • Author Owner

    Can you run poetry --version in the test to check if it's not calling an other poetry installed somewhere else?

  • Author Owner

    Do you have any error when running poetry run silkaj on this commit and on previous commit (git checkout HEAD~1)?

  • I cloned the repo to a fresh dir to avoid directory-specific problems. I still get this issue.

    • I can poetry run silkaj info (outside of poetry shell, naturally) on HEAD and HEAD~1.

    • Inside poetry shell, unsurprisingly I get:

    $ poetry run silkaj info
    /home/thomas/.cache/pypoetry/virtualenvs/silkaj-Yw96Ud83-py3.7/bin/python3: No module named poetry

    I can't run poetry --version in tests.

    edit: using this function:

    def test_poetry():
        output = check_output(["poetry", "--version"])
        print (output.decode())
        assert False
    $ pytest -k poetry -vvvvv
    ...
    Poetry version 1.0.0b1

    So, tests are calling another poetry version than the one installed. I updated Poetry not long ago... I don't remember which version I was running before.

    Edited by matograine
  • matograine mentioned in issue #399

    mentioned in issue #399

  • OK, solved, it was because of a faulty alias on my side. Sorry for the trouble.

  • Author Owner

    Good you fixed it!

  • Moul changed title from Update black to v21.4b2 and allow to install as pre-release to Bump black to v21.4b2 and allow to install as pre-release

    changed title from Update black to v21.4b2 and allow to install as pre-release to Bump black to v21.4b2 and allow to install as pre-release

Please register or sign in to reply
Loading