[enh] add support for multiple outputs
Allows Silkaj to make a transaction to multiple receivers using a new separator in --output
option:
--output=<public key>[:checksum][,<public key>[:checksum]]
So the transaction's --amount
is sent to each output, which means if we send --amount 10
with 3 outputs we actually send 30.
I've tried to integrate it without many modifications as I don't know the possible impacts elsewhere.
Merge request reports
Activity
changed milestone to %0.6.0
assigned to @moul
Firt of all. Thanks for your contribution!
Silkaj workflow is:
master <— dev <– branch
. I changed the target of this PR todev
branch. There is conflicts to solve.
Otherwise, I would like to keep the constancy with
amount
command with which we can specify pubkeys splited with colons. Unfortunatly, there is already a pubkey’s sum check which already uses colons to seperate the pubkey from the checksum. If we don’t find a better solution, we will have to keep it that way for now.
This is the first review. Then, I will need to test it.
added 26 commits
-
4ded4148...36a15c0c - 25 commits from branch
clients/python:dev
- b2319de2 - [enh] add support for multiple outputs
-
4ded4148...36a15c0c - 25 commits from branch
Ok, tested. It works!
And the commit has been rebased on
dev
branch.Edited by Mouladded 2 commits
- bab25f5c - [enh] #83 (closed): add support for multiple outputs
- 5af9bc89 - [enh] #83 (closed): tx: refactor multiple outputs:
- Resolved by Moul
- Resolved by Moul
Ok, we are close to merge it.
I published a commit which refactor. @c-geek, you can test it.
I have to figure out for the three upper points.
added 1 commit
- 86fdc27f - [enh] #83 (closed), #72 (closed): handle the enough sources’ check for multiple outputs,
added 4 commits
- 8f6a2fcf - [mod] #72 (closed): Remove duplicate check for outputBackChange pubkey.
- b3a6344a - [enh] #83 (closed): handle the enough sources’ check for multiple outputs.
- 5e76a2c5 - [enh] #83 (closed), #72 (closed): add proper pubkey’s checksum check.
- 2259d3df - [mod] #83 (closed), #72 (closed): keep constancy with amount cmd, using ':' as pubkeys separator
Toggle commit listadded 1 commit
- ac5c1b1a - [mod] #83 (closed): remove duplicate 'enough money' check.
mentioned in commit 4a4d80ae