Skip to content
Snippets Groups Projects

Test struture creation

Merged Sébastien DA ROCHA requested to merge cebash/silkaj:85_create_test_struture into dev
All threads resolved!

Provide basic tests

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul assigned to @moul

    assigned to @moul

  • What is the status of this PR?

  • I wanted to add some examples of tests before merging, but I've being really busy these days.

    For me it's still in WIP, but I can write some doc to explain how to run tests and get the coverage rate / badge, merge the request and work on more tests latter.

    I'm not sure I can make more until mid september :-/

  • Ok, no worries. Take the time you need.

    This is still an ongoing reflection.

    On my side, I am also busy. I want to further more this 0.6.0 milestone.

  • added 26 commits

    • 636259d6...c7675605 - 14 commits from branch clients/python:dev
    • e6a3a05f - [enh] add pytest as a dev dependency
    • f592996d - [enh] ignore pytest cache files
    • b604a26a - [enh] Implement the first test
    • 8b06495f - [mod] coverage badge
    • f46a7506 - [enh] generate coverage bagde
    • 3aa915de - [enh] add an integration test for wot
    • 9c981080 - [mod] Made badges generator runnable
    • 96bce3df - [mod] ignore generated badges
    • 9ec87d05 - [enh] add a test on id command
    • dbbb3f94 - [enh] add test on amount command
    • dc97245f - [mod] rename end to end tests
    • 6304320e - [enh] Add basic unit test with mock (cert.certification_confirmation)

    Compare with previous version

  • added 1 commit

    • ae6f77f0 - [enh] Add a test on silkaj.tx.truncBase as an example to use

    Compare with previous version

  • added 1 commit

    • 62212186 - [enh] Add a test on silkaj.tx.truncBase as an example to parametrized test

    Compare with previous version

  • Moul changed milestone to %0.7.0

    changed milestone to %0.7.0

  • @moul I think I'll take some time next week to commit changes I've made in local to handle coverage.

    Then I'll rework the commits line too, it's quite messy.

    For the other features I wanted to had, I'll create some small issues.

    And then maybe we should merge this branch even if it's not perfect ?

  • Nice!

    Yes, sure we should merge this as soon as possible even if not perfect.

    We need to lock features in order to start breaking everything without wondering :wink:

  • added 63 commits

    • 62212186...2a915498 - 53 commits from branch clients/python:dev
    • 3f97d712 - [enh] add pytest as a dev dependency
    • f89bd29d - [enh] Implement the first test
    • bfbd6c14 - [enh] add test for wot command
    • e51504f1 - [enh] add test for id command
    • 5c5599c4 - [enh] add test for amount command
    • 18ac38b4 - [enh] Add basic unit test with mock (cert.certification_confirmation)
    • 34134179 - [enh] Add a test on silkaj.tx.truncBase as an example to parametrized test
    • 8fd6c8d3 - [mod] coverage badge
    • 9372e226 - [mod] Coverage badge
    • 2669c0a0 - [mod] Documentation on test and coverage

    Compare with previous version

  • Sébastien DA ROCHA unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 1 commit

    • 1ae009ee - [mod] Documentation on test and coverage

    Compare with previous version

  • mentioned in issue #147

  • Moul
  • Moul
  • Moul
  • Moul
  • added 1 commit

    Compare with previous version

  • added 1 commit

    • de6d9c2b - [mod] code coloration in test_and_coverage.md

    Compare with previous version

  • added 1 commit

    • f6304352 - [fix] intall coverage in dev env

    Compare with previous version

  • Moul added 2 commits

    added 2 commits

    • 94c4ec14 - [doc] Document test and coverage
    • 1fd7b852 - [fix] intall coverage in dev env

    Compare with previous version

  • I did squash three commits about the document and pushed force.

    Does the MR looks good to you?

    It looks fine from my point of view.

    Edited by Moul
  • Moul changed title from 85 create test struture to Test struture creation

    changed title from 85 create test struture to Test struture creation

  • We can may be create a .gitlab-ci.yml to run those tests at every commits on every branches.

  • Yep, it's fine !

  • For the .gitlab-ci.yml, yes but it requires a little design and work, i.e. I don't know if we can use the same worker as sakia, we need to setup a docker image, ...

    It's not very complicated but maybe we should do another issue for this ?

  • Moul resolved all discussions

    resolved all discussions

  • Moul mentioned in issue #149 (closed)

    mentioned in issue #149 (closed)

  • Ok, you are right. Let’s merge this one as we can already test locally.

    I created #149 (closed).

  • Moul added 8 commits

    added 8 commits

    • 1425993b - [enh] add pytest and coverage as dev dependencies
    • 5109fd35 - [enh] Implement the first test
    • 638eede8 - [enh] add test for wot command
    • 2aecdebf - [enh] add test for id command
    • 212a6745 - [enh] add test for amount command
    • cdbb86da - [enh] Add basic unit test with mock (cert.certification_confirmation)
    • 7599b8d9 - [enh] Add a test on silkaj.tx.truncBase as an example to parametrized test
    • 387e3e94 - [doc] Document test and coverage

    Compare with previous version

  • Moul mentioned in commit d4023d98

    mentioned in commit d4023d98

  • merged

  • Moul mentioned in commit 20b905e5

    mentioned in commit 20b905e5

  • Moul added Dev Env Doc/Website labels and removed Doing label

    added Dev Env Doc/Website labels and removed Doing label

  • Please register or sign in to reply
    Loading