Skip to content
Snippets Groups Projects

Include Ğ1 monetary license into the wheel

Closed Moul requested to merge include_g1_license_in_wheel into main

When running a pip installation, the license tab would crash due to missing license files

Edited by Moul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moul added Bug label

    added Bug label

  • Moul requested review from @vtexier

    requested review from @vtexier

  • Moul assigned to @moul

    assigned to @moul

  • Moul changed the description

    changed the description

  • Good catch !

    But we should not include .po files from locales directory in the wheel. Only .mo and .md files.

    Edited by Vincent Texier
  • Author Owner

    I don’t know what’s wrong with the CI/CD build. When I try to build it locally with no change, as on main branch, I get everything included (po, mo, md) with an empty configuration:

    [tool.setuptools.packages.find]
    where = ["."] 

    I tried different stuff, but nothing successful. I also tried to excludes the po, but they remain included.

    [tool.setuptools.packages.find]
    where = ["."]
    
    [tool.setuptools.package-data] 
    tikka = ["*.mo", "*.json", "*.yaml", "*.sql"]
    
    [tool.setuptools.exclude-package-data]
    tikka = ["application.po"]
    # tikka.locales.fr_FR.LC_MESSAGES = ["application.po"]
    # tikka.locales.en_EN.LC_MESSAGES = ["application.po"]

    The fact that uv implements different back-ends, setuptools in this case, does not make things clear. Is uv correctly implementing the other back-ends (poetry, hatch, setuptools)?


    When running uv build, I get:

    adding 'tikka/locales/en_US/licence_g1.md'
    adding 'tikka/locales/en_US/LC_MESSAGES/application.mo'
    adding 'tikka/locales/en_US/LC_MESSAGES/application.po'
    adding 'tikka/locales/fr_FR/licence_g1.md'
    adding 'tikka/locales/fr_FR/LC_MESSAGES/application.mo'
    adding 'tikka/locales/fr_FR/LC_MESSAGES/application.po'

    While in the CI:

    adding 'tikka/locales/en_US/LC_MESSAGES/application.mo'
    adding 'tikka/locales/fr_FR/LC_MESSAGES/application.mo'

    May be a different setuptools version? I run v74.1.3, while python:3.9-slim-bullseye image runs v58.1.0.

  • Moul unassigned @moul

    unassigned @moul

  • Moul removed review request for @vtexier

    removed review request for @vtexier

  • Author Owner

    I give up on this one. Too complex to solve compared to the effort originally expected.

    I tried to build Tikka on python:3.10-slim, with setuptools v65.5.1, now, nothing is included. I don’t understand setuptools backend.

  • Moul mentioned in issue #12 (closed)

    mentioned in issue #12 (closed)

  • Author Owner

    Follow-up in #12 (closed).

  • closed

Please register or sign in to reply
Loading