Skip to content
Snippets Groups Projects
Nicolas80's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

Une précision pour commencer; je suis assez nouveau dans les devs de la Gune et je connais surtout Gcli parceque j'ai récemment faire un changement...

Nicolas80's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

EDIT: J'avais oublié de répondre pour la sélection du compte source - je reprend mon exemple du message précédent...

Fred's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

Comment choisir un wallet dans le vault comme source du payement ?...

Fred's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

@Nicolas80, merci pour ta réponse......

Nicolas80's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

To know which arguments are allowed or not; you can always add --help on any of the Gcli commands 😃

Nicolas80's avatar
commented on issue #47 "How to import g1v1 key into gcli vault and use them in v2s" at clients / Rust / Ğcli-v2s

I'm not sure what you mean by "sec" part; but the command for vault import does not allow to provide the secret part directly...

Nicolas80's avatar
approved merge request !46 "Json output" at clients / Rust / Ğcli-v2s
Nicolas80's avatar
commented on merge request !46 "Json output" at clients / Rust / Ğcli-v2s

Really nice to support JSON output for all of those (as long as we don't put the JSON format by default 😃)

Nicolas80's avatar
commented on merge request !45 "Nostr" at clients / Rust / Ğcli-v2s

I don't know NOSTR but I find odd that the way to make a valid signature would be non-deterministic and require 3 different signing methods ?...

Nicolas80's avatar
commented on merge request !45 "Nostr" at clients / Rust / Ğcli-v2s

I would keep the "address" last, also because I add the Vault data when that address is in the vault:...

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

Actually, I think it's even worse; I tried importing for a key file I had for "Alice"; which have address:5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNo...

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

I'm fine with using ed25519 by default now 😃...

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

I added another comment about the base "-c" argument we should probably still add.

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

Careful that for now, the method catch_known is currently matching the "predefined" SS58 addresses computed with "sr25519" scheme; so it won't work...

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

If we want to add the base Argument "-c" for the crypto-scheme we can adapt the Args struct inside main.rs....

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

If we do keep the secret_format we should update that code that tries to ensure nothing illegal is persisted in DB (distinction between base and de...

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

I guess it's fine to not have the confirm since we can vault remove without requiring the password.

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

Ok with the change; but should also adapt the doc

Nicolas80's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

@pokapow feel free to disagree with my remarks; I'm still new to this 😃 (and feel free to respond in French as well if you prefer)....

poka's avatar
commented on merge request !44 "feat: Can choose between ed25519 ans sr25519" at clients / Rust / Ğcli-v2s

I think it will continue to work even for people who already import in sr25519, no ?...