Skip to content
Snippets Groups Projects

Replace currency "values" by currency "amounts"

1 unresolved thread

Merge request reports

Approval is optional

Closed by nanocryknanocryk 7 years ago (Feb 15, 2018 10:33am UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
264 264 | Data type | Payload size | Description
265 265 |:---------:|:------------:|:------
266 266 | 0 | 32 | account
267 | 2 | 32/64 | [ed25519] public/private key
    1. Why store the signature in a checksumed value ? This is never used by users.
    2. Why remove the private key ?

    You should post a comment on the RFC merge request and not create your own, it'll be easier to track and manage.

    Edited by nanocryk
  • Sorry, I don't remember having made a merge request for those changes about private key, or did I accidentally through the command line ? I don't understand what happened. I was preparing this for commenting and asking questions because I was not sure to understand.

    1.Why store the signature in a checksumed value ? This is never used by users.

    That is where I think I may have not understand the purpose of these datatypes.

    2.Why remove the private key ?

    If the protocol manipulates private keys, they are not private anymore.

    But again, I intented to ask the question before pushing a merge request.If i'm wrong can you clarify what is the context with an example ?

    Edited by mmpio
  • This data type is made to provide checksumed, currency-specific data containers where you can choose the cryptosystem you use. It would be used in clients to send currency to other addresses (to public keys or to script hashes directly) or to directly connect with the private key (with a checksum and "currency lock" for user-friendliness).

    It's also used as a key format in script to test the cryptosystem and allow soft forks (unknown cryptosystem is "anyone can spend", see The script system).

    For future reviews, you should go to the RFC5 merge request, go to the file and comment the line.

    Edited by nanocryk
  • Please register or sign in to reply
  • As for the title I changed it, thanks for the suggestion.

  • closed

  • Please register or sign in to reply
    Loading