[fix] common-doc: #134 remove unwrap and deny its use

lib/dubp/common-doc/src/blockstamp.rs

@@ -161,13 +161,11 @@ impl Blockstamp {
     pub fn from_string(src: &str) -> Result<Blockstamp, BlockstampParseError> {
         let mut split = src.split('-');
 
-        if split.clone().count() != 2 {
-            Err(BlockstampParseError::InvalidFormat())
-        } else {
-            let id = split.next().unwrap().parse::<u32>();
-            let hash = Hash::from_hex(split.next().unwrap())?;
+        match (split.next(), split.next(), split.next()) {
+            (Some(id), Some(hash), None) => {
+                let hash = Hash::from_hex(hash)?;
 
-            if let Ok(id) = id {
+                if let Ok(id) = id.parse::<u32>() {
                     Ok(Blockstamp {
                         id: BlockNumber(id),
                         hash: BlockHash(hash),
@@ -176,5 +174,7 @@ impl Blockstamp {
                     Err(BlockstampParseError::InvalidBlockNumber())
                 }
             }
+            _ => Err(BlockstampParseError::InvalidFormat()),
+        }
     }
 }

lib/dubp/common-doc/src/lib.rs

@@ -16,6 +16,8 @@
 //! Provide common tools for DUBP.
 
 #![deny(
+    clippy::option_unwrap_used,
+    clippy::result_unwrap_used,
     missing_debug_implementations,
     missing_copy_implementations,
     trivial_casts,