Replace all panics! by fatal_error()

changed milestone to %v0.3 Minimal mirror node

added D-easy label

@librelois : interesting issue. I imagine something like:

use std::process;

#[panic_handler]
fn panic(info: &PanicInfo) -> ! {
    println!("{}", info);
    process::exit(-1);
}

But write it where? I have to take a look.

EDIT: I read a function fatal_error() defined in the crate /lib/tools/common-tools/src. You may be talking about this crate. Then I have only to replace each call of panic to fatal_error.

Indeed do you think that redefine panic() by the content of fatal_error() is better than replace each calls of panics by the call of fatal_error()?

The best is to replace all panic calls by fatal_error calls, and those for 2 reasons:

• Making the code easier to understand for future rust developers who will arrive on the project they already know panic, giving it another behavior will confuse them.
• This saves us from having to maintain our own panic fork on the days when its implementation in std will change.

Nice. I am going to solve this issue.

@counter-reverse Please respect the workflow and create a branch and an MR from the gitlab.

assigned to @counter-reverse

mentioned in merge request !114 (closed)

created merge request !114 (closed) to address this issue

mentioned in issue #130 (closed)

mentioned in merge request !115 (closed)

added S-to do in priority label

added W-urgent label

@counter-reverse je viens de passer ce ticket en URGENT car il est nécessaire pour pouvoir merger le ticket #135 (closed) .

Je n'ai pas de nouvelles depuis un mois donc je suppose que tu n'a plus le temps, ce n'est pas grave mais du coup je suis obligé de reprendre la main sur ce ticket car il empêche la finalisation de la MR !138 (merged) :)

assigned to @librelois and unassigned @counter-reverse

mentioned in merge request !138 (merged)

assigned to @JonasSprenger and unassigned @librelois

@JonasSprenger attention il y a une subtilité concernant ce ticket : tout ce qui se passe avant l'initialisation du logger doit rester en panic!().

En cas de doute sur un panic, n'hésite pas a me poser la question :)

mentioned in merge request !141 (merged)

closed