TransactionDocument: replace Vec fields by SmallVec
https://crates.io/crates/smallvec
issuers, signatures : SmallVec<[T; 4]>
inputs, unlocks : SmallVec<[T; 32]>
outputs : SmallVec<[T; 8]>
Activity
added C-documents D-easy labels
changed milestone to %v0.4 Full Mirror Node
added T-optimization label
I'm working on it, and I have some questions :
1 - Why a size of 4 for issuers and signatures field, if most of the time there will be only one of each ? And If there is more, then the SmallVec will move this field into the heap.
2 - The size of unlocks should be equal to the size of outputs, no ? Maybe I haven't understood correctly what's the signification of the unlock field...
By the way, can someone assign this issue to me ? Like that, I can create a pull request.
assigned to @laguionb
1 - To prepare for complex transactions that could become commonplace. allocating the heap as early as the 2nd element is not relevant. 2 - No the unlocks are for inputs. There is one unlock per input. You would have realized this by looking at the existing transactions in blockchain :)
created merge request !283 (closed) to address this issue
mentioned in merge request !283 (closed)
created merge request !284 to address this issue
mentioned in merge request !284
