CLI improvements

• Remove clap relics

Better input, help, and print CLI interface:

• Typo
• Better English
• …

added 5 commits

• 2128f5ea...4e902403 - 2 commits from branch dev
• 4a3f79a7 - [mod] remove old clap CLI tool usage relics
• bd762e3a - [mod] improve command line interface
• 8e0bfca0 - [mod] improve keys sub-command interface

Compare with previous version

Tests, clippy, and fmt passed.

I rebased on dev branch (push --force) and the piplines results are not displayed here.

Did this already happen?

@moul Thank you very much for this contribution:)

I just checked the changes and everything seems okay.

You just need to rename your commit according to the project conventions and then I will merge.

I rebased on dev branch (push --force) and the piplines results are not displayed here.

Yes it is normal, the CI only starts when the changes concern the rust code, but the 2 commits that you have to recover by making a rebase have not modified the rust code.

May I ask why did you run away from clap tool?

We always use clap in reality, StructOpt is based on clap.

StructOpt is much cleaner because it allows you to directly obtain a Rust structure containing all the information of the command entered by the user.

Also StructOpt is becoming a standard in the Rust ecosystem, most cli programs now use StructOpt.

Thanks for the explanation.

There is an incoming MR to add new [enh] and [mod] types.

But, I am unable to push

Would that be ok?

There is an incoming MR to add new [enh] and [mod] types.

We do not use the same commit naming conventions in durs project, [enh] and [mod] don't exist. Please look at the project conventions : https://git.duniter.org/nodes/rust/duniter-rs/blob/dev/doc/fr/developpeurs/conventions-git.md#liste-des-types-de-commit

added 3 commits

• 46c42649 - [mod] core: remove old clap CLI tool usage relics
• 7fc584c8 - [mod] core: improve command line interface
• e40a09ce - [mod] core: improve keys sub-command interface

Compare with previous version

added 3 commits

• b5000027 - [ref] core: remove old clap CLI tool usage relics
• cc8faed0 - [ref] core: improve command line interface
• e9a26273 - [ref] core: improve keys sub-command interface

Compare with previous version

Ok, j’ai fait usage de [ref].

added 7 commits

• e9a26273...5fd550fc - 4 commits from branch dev
• 12aea3cb - [ref] core: remove old clap CLI tool usage relics
• 9f15159b - [ref] core: improve command line interface
• 44eda1c8 - [ref] core: improve keys sub-command interface

Compare with previous version

Review: ok

Thank you very much for this excellent contribution :)

enabled an automatic merge when the pipeline for 44eda1c8 succeeds

merged